Fix vcvars calls. Fix MSVC DLL build step echos#3603
Closed
iboB wants to merge 1 commit intoocornut:masterfrom
Closed
Fix vcvars calls. Fix MSVC DLL build step echos#3603iboB wants to merge 1 commit intoocornut:masterfrom
iboB wants to merge 1 commit intoocornut:masterfrom
Conversation
Contributor
Author
|
Expected error which is fixed by #3601 is here: https://github.com/ocornut/imgui/pull/3603/checks?check_run_id=1420415264#step:9:27 |
Owner
|
Thanks a lot for investigating this! |
ocornut
pushed a commit
that referenced
this pull request
Nov 18, 2020
Owner
|
Merged jointly in fcc2b71, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #3601
Note that the CI is expected to fail after this commit. The fix is in the aforementioned PR
Two CI steps weren't being run. Calling
vcvarsallcauses the CI step to immediately complete with a success ignoring subsequent commands.The fix is to use
callof a complete batch file (the steps are being exectuted as a batch file and the correct way to "source" batch from batch is to usecall)Another fix here is the cmd
echo-s in the MSVC DLL build step.echoon cmd doesn't work the same way it does on bash. The single quotes are literally echoed back. So removing the quotes fixes echo to output valid C++