Backends: OpenGL3: Add compatibility of GL_VERSION for GL 2.x#3530
Closed
xndcn wants to merge 1 commit intoocornut:masterfrom
Closed
Backends: OpenGL3: Add compatibility of GL_VERSION for GL 2.x#3530xndcn wants to merge 1 commit intoocornut:masterfrom
xndcn wants to merge 1 commit intoocornut:masterfrom
Conversation
GL_MAJOR_VERSION and GL_MINOR_VERSION are available on GL 3.0 and above. So we have to parse GL_VERSION under GL 2.x
ocornut
pushed a commit
that referenced
this pull request
Oct 15, 2020
GL_MAJOR_VERSION and GL_MINOR_VERSION are available on GL 3.0 and above. So we have to parse GL_VERSION under GL 2.x
Owner
|
Merged with minor changes (using sscanf since it's already used in this file). Thank you ! |
|
Issue reintroduced in 459de65. |
grauw
added a commit
to grauw/imgui
that referenced
this pull request
Feb 9, 2023
GL_MAJOR_VERSION and GL_MINOR_VERSION are available on GL 3.0 and above. So we have to parse GL_VERSION under GL 2.x Regressed since 459de65 See ocornut#3530
grauw
added a commit
to grauw/gl3w_stripped
that referenced
this pull request
Feb 9, 2023
GL_MAJOR_VERSION and GL_MINOR_VERSION are available on GL 3.0 and above. So we have to parse GL_VERSION under GL 2.x Reference https://www.khronos.org/opengl/wiki/OpenGL_Context#Context_information_queries See ocornut/imgui#3530
grauw
added a commit
to grauw/imgui
that referenced
this pull request
Feb 9, 2023
…t#6154) GL_MAJOR_VERSION and GL_MINOR_VERSION are available on GL 3.0 and above. So we have to parse GL_VERSION under GL 2.x Reference https://www.khronos.org/opengl/wiki/OpenGL_Context#Context_information_queries Regressed since 459de65 See ocornut#3530
ocornut
pushed a commit
that referenced
this pull request
Feb 14, 2023
…2.x (#6154, #4445, #3530) GL_MAJOR_VERSION and GL_MINOR_VERSION are available on GL 3.0 and above. So we have to parse GL_VERSION under GL 2.x Reference https://www.khronos.org/opengl/wiki/OpenGL_Context#Context_information_queries Regressed since 459de65 See #3530
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we use imgui_impl_opengl3 as backend in desktop GL 2.x, the g_GlVersion may be initialized with weird numbers and maybe pass the checking like (g_GlVersion >= 330)
GL_MAJOR_VERSION and GL_MINOR_VERSION are available on GL 3.0 and above. So we have to parse GL_VERSION under GL 2.x
reference: https://www.khronos.org/opengl/wiki/OpenGL_Context#Context_information_queries