Impl idea

achabense · achabense · commit ec6fb8d8f04a · 2025-06-13T15:45:39.000+08:00
diff --git a/examples/example_win32_directx9/main.cpp b/examples/example_win32_directx9/main.cpp
@@ -25,6 +25,30 @@ void CleanupDeviceD3D();
 void ResetDevice();
 LRESULT WINAPI WndProc(HWND hWnd, UINT msg, WPARAM wParam, LPARAM lParam);
 
+bool close_button_no_focus = false;
+
+static void example() {
+    static bool b = true, c = true;
+    const ImGuiWindowFlags flags = ImGuiWindowFlags_AlwaysAutoResize | ImGuiWindowFlags_NoSavedSettings;
+    if (ImGui::Begin("Window A", 0, flags)) {
+        ImGui::Checkbox("Close button: don't focus window", &close_button_no_focus);
+        ImGui::Checkbox("Window B", &b);
+        ImGui::Checkbox("Window C", &c);
+
+    }
+    ImGui::End();
+    if (b) {
+        ImGui::Begin("Window B", &b, flags);
+        ImGui::Text("--- Window B ---");
+        ImGui::End();
+    }
+    if (c) {
+        ImGui::Begin("Window C", &c, flags);
+        ImGui::Text("--- Window C ---");
+        ImGui::End();
+    }
+}
+
 // Main code
 int main(int, char**)
 {
@@ -154,6 +178,8 @@ int main(int, char**)
             ImGui::End();
         }
 
+        example();
+
         // 3. Show another simple window.
         if (show_another_window)
         {
diff --git a/imgui_widgets.cpp b/imgui_widgets.cpp
@@ -498,6 +498,10 @@ void ImGui::BulletTextV(const char* fmt, va_list args)
 //   with same ID and different MouseButton (see #8030). You can fix it by:
 //       (1) switching to use a single ButtonBehavior() with multiple _MouseButton flags.
 //    or (2) surrounding those calls with PushItemFlag(ImGuiItemFlags_AllowDuplicateId, true); ... PopItemFlag()
+
+extern bool close_button_no_focus;
+static bool button_behavior_no_focus = false;
+
 bool ImGui::ButtonBehavior(const ImRect& bb, ImGuiID id, bool* out_hovered, bool* out_held, ImGuiButtonFlags flags)
 {
     ImGuiContext& g = *GImGui;
@@ -541,7 +545,7 @@ bool ImGui::ButtonBehavior(const ImRect& bb, ImGuiID id, bool* out_hovered, bool
             {
                 pressed = true;
                 g.DragDropHoldJustPressedId = id;
-                FocusWindow(window);
+                /*if(!button_behavior_no_focus) */FocusWindow(window);
             }
         }
 
@@ -580,12 +584,13 @@ bool ImGui::ButtonBehavior(const ImRect& bb, ImGuiID id, bool* out_hovered, bool
                     g.ActiveIdMouseButton = mouse_button_clicked;
                     if (!(flags & ImGuiButtonFlags_NoNavFocus))
                     {
-                        SetFocusID(id, window);
-                        FocusWindow(window);
+                        // (Code path used by CloseButton)
+                        if (!button_behavior_no_focus) SetFocusID(id, window);
+                        if (!button_behavior_no_focus) FocusWindow(window);
                     }
                     else
                     {
-                        FocusWindow(window, ImGuiFocusRequestFlags_RestoreFocusedChild); // Still need to focus and bring to front, but try to avoid losing NavId when navigating a child
+                        /*if (!button_behavior_no_focus)*/ FocusWindow(window, ImGuiFocusRequestFlags_RestoreFocusedChild); // Still need to focus and bring to front, but try to avoid losing NavId when navigating a child
                     }
                 }
                 if ((flags & ImGuiButtonFlags_PressedOnClick) || ((flags & ImGuiButtonFlags_PressedOnDoubleClick) && g.IO.MouseClickedCount[mouse_button_clicked] == 2))
@@ -598,12 +603,12 @@ bool ImGui::ButtonBehavior(const ImRect& bb, ImGuiID id, bool* out_hovered, bool
                     g.ActiveIdMouseButton = mouse_button_clicked;
                     if (!(flags & ImGuiButtonFlags_NoNavFocus))
                     {
-                        SetFocusID(id, window);
-                        FocusWindow(window);
+                        /*if (!button_behavior_no_focus)*/ SetFocusID(id, window);
+                        /*if (!button_behavior_no_focus)*/ FocusWindow(window);
                     }
                     else
                     {
-                        FocusWindow(window, ImGuiFocusRequestFlags_RestoreFocusedChild); // Still need to focus and bring to front, but try to avoid losing NavId when navigating a child
+                        /*if (!button_behavior_no_focus)*/ FocusWindow(window, ImGuiFocusRequestFlags_RestoreFocusedChild); // Still need to focus and bring to front, but try to avoid losing NavId when navigating a child
                     }
                 }
             }
@@ -615,7 +620,7 @@ bool ImGui::ButtonBehavior(const ImRect& bb, ImGuiID id, bool* out_hovered, bool
                     if (!has_repeated_at_least_once)
                         pressed = true;
                     if (!(flags & ImGuiButtonFlags_NoNavFocus))
-                        SetFocusID(id, window); // FIXME: Lack of FocusWindow() call here is inconsistent with other paths. Research why.
+                        /*if (!button_behavior_no_focus)*/ SetFocusID(id, window); // FIXME: Lack of FocusWindow() call here is inconsistent with other paths. Research why.
                     ClearActiveID();
                 }
             }
@@ -858,7 +863,13 @@ bool ImGui::CloseButton(ImGuiID id, const ImVec2& pos)
     bool is_clipped = !ItemAdd(bb_interact, id);
 
     bool hovered, held;
+    if (close_button_no_focus) {
+        button_behavior_no_focus = true;
+    }
     bool pressed = ButtonBehavior(bb_interact, id, &hovered, &held);
+    if (close_button_no_focus) {
+        button_behavior_no_focus = false;
+    }
     if (is_clipped)
         return pressed;
 

Original file line number	Diff line number	Diff line change
`@@ -498,6 +498,10 @@ void ImGui::BulletTextV(const char* fmt, va_list args)`
`498`	`498`	`// with same ID and different MouseButton (see #8030). You can fix it by:`
`499`	`499`	`// (1) switching to use a single ButtonBehavior() with multiple _MouseButton flags.`
`500`	`500`	`// or (2) surrounding those calls with PushItemFlag(ImGuiItemFlags_AllowDuplicateId, true); ... PopItemFlag()`
	`501`	`+`
	`502`	`+extern bool close_button_no_focus;`
	`503`	`+static bool button_behavior_no_focus = false;`
	`504`	`+`
`501`	`505`	`bool ImGui::ButtonBehavior(const ImRect& bb, ImGuiID id, bool* out_hovered, bool* out_held, ImGuiButtonFlags flags)`
`502`	`506`	`{`
`503`	`507`	`ImGuiContext& g = *GImGui;`
`@@ -541,7 +545,7 @@ bool ImGui::ButtonBehavior(const ImRect& bb, ImGuiID id, bool* out_hovered, bool`
`541`	`545`	`{`
`542`	`546`	`pressed = true;`
`543`	`547`	`g.DragDropHoldJustPressedId = id;`
`544`		`- FocusWindow(window);`
	`548`	`+ /if(!button_behavior_no_focus) /FocusWindow(window);`
`545`	`549`	`}`
`546`	`550`	`}`
`547`	`551`
`@@ -580,12 +584,13 @@ bool ImGui::ButtonBehavior(const ImRect& bb, ImGuiID id, bool* out_hovered, bool`
`580`	`584`	`g.ActiveIdMouseButton = mouse_button_clicked;`
`581`	`585`	`if (!(flags & ImGuiButtonFlags_NoNavFocus))`
`582`	`586`	`{`
`583`		`- SetFocusID(id, window);`
`584`		`- FocusWindow(window);`
	`587`	`+ // (Code path used by CloseButton)`
	`588`	`+ if (!button_behavior_no_focus) SetFocusID(id, window);`
	`589`	`+ if (!button_behavior_no_focus) FocusWindow(window);`
`585`	`590`	`}`
`586`	`591`	`else`
`587`	`592`	`{`
`588`		`- FocusWindow(window, ImGuiFocusRequestFlags_RestoreFocusedChild); // Still need to focus and bring to front, but try to avoid losing NavId when navigating a child`
	`593`	`+ /if (!button_behavior_no_focus)/ FocusWindow(window, ImGuiFocusRequestFlags_RestoreFocusedChild); // Still need to focus and bring to front, but try to avoid losing NavId when navigating a child`
`589`	`594`	`}`
`590`	`595`	`}`
`591`	`596`	`if ((flags & ImGuiButtonFlags_PressedOnClick) \|\| ((flags & ImGuiButtonFlags_PressedOnDoubleClick) && g.IO.MouseClickedCount[mouse_button_clicked] == 2))`
`@@ -598,12 +603,12 @@ bool ImGui::ButtonBehavior(const ImRect& bb, ImGuiID id, bool* out_hovered, bool`
`598`	`603`	`g.ActiveIdMouseButton = mouse_button_clicked;`
`599`	`604`	`if (!(flags & ImGuiButtonFlags_NoNavFocus))`
`600`	`605`	`{`
`601`		`- SetFocusID(id, window);`
`602`		`- FocusWindow(window);`
	`606`	`+ /if (!button_behavior_no_focus)/ SetFocusID(id, window);`
	`607`	`+ /if (!button_behavior_no_focus)/ FocusWindow(window);`
`603`	`608`	`}`
`604`	`609`	`else`
`605`	`610`	`{`
`606`		`- FocusWindow(window, ImGuiFocusRequestFlags_RestoreFocusedChild); // Still need to focus and bring to front, but try to avoid losing NavId when navigating a child`
	`611`	`+ /if (!button_behavior_no_focus)/ FocusWindow(window, ImGuiFocusRequestFlags_RestoreFocusedChild); // Still need to focus and bring to front, but try to avoid losing NavId when navigating a child`
`607`	`612`	`}`
`608`	`613`	`}`
`609`	`614`	`}`
`@@ -615,7 +620,7 @@ bool ImGui::ButtonBehavior(const ImRect& bb, ImGuiID id, bool* out_hovered, bool`
`615`	`620`	`if (!has_repeated_at_least_once)`
`616`	`621`	`pressed = true;`
`617`	`622`	`if (!(flags & ImGuiButtonFlags_NoNavFocus))`
`618`		`- SetFocusID(id, window); // FIXME: Lack of FocusWindow() call here is inconsistent with other paths. Research why.`
	`623`	`+ /if (!button_behavior_no_focus)/ SetFocusID(id, window); // FIXME: Lack of FocusWindow() call here is inconsistent with other paths. Research why.`
`619`	`624`	`ClearActiveID();`
`620`	`625`	`}`
`621`	`626`	`}`
`@@ -858,7 +863,13 @@ bool ImGui::CloseButton(ImGuiID id, const ImVec2& pos)`
`858`	`863`	`bool is_clipped = !ItemAdd(bb_interact, id);`
`859`	`864`
`860`	`865`	`bool hovered, held;`
	`866`	`+ if (close_button_no_focus) {`
	`867`	`+ button_behavior_no_focus = true;`
	`868`	`+ }`
`861`	`869`	`bool pressed = ButtonBehavior(bb_interact, id, &hovered, &held);`
	`870`	`+ if (close_button_no_focus) {`
	`871`	`+ button_behavior_no_focus = false;`
	`872`	`+ }`
`862`	`873`	`if (is_clipped)`
`863`	`874`	`return pressed;`
`864`	`875`