This repository was archived by the owner on Jun 1, 2021. It is now read-only.
refactor(): rework of ocibuilder library and cli#65
Merged
artbegolli merged 242 commits intomasterfrom Dec 2, 2019
Merged
Conversation
…o refactor/buildah-cmd-interface
Collaborator
Author
|
This is ready to review - ton of changes in this one, restructures a bunch of the codebase Ignore the number of commits - these came in from the pipeline branch. |
artbegolli
commented
Nov 22, 2019
artbegolli
commented
Nov 22, 2019
artbegolli
commented
Nov 22, 2019
|
|
||
| stdout, stderr, err := execute(&cmd) | ||
| if err != nil { | ||
| cli.Logger.WithError(err).Errorln("error building image...") |
Collaborator
Author
There was a problem hiding this comment.
Wrap the error error.Wrap() instead of logging the error all the time
Collaborator
Author
There was a problem hiding this comment.
One note on this - error.Wrap() works but the format of the new error is hard to ready and looks like is just concatenated. I'd prefer to continue logging but only when useful fields or additional information is being added to the logs
What are your thoughts?
VaibhavPage
approved these changes
Dec 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.