Metaquot: Embed errors in the AST instead of raising by Burnleydev1 · Pull Request #397 · ocaml-ppx/ppxlib

Burnleydev1 · 2023-03-15T08:15:19Z

No description provided.

panglesd

You are getting closer!

But in your (draft) PR, there are still exceptions that are raised!

You also need to modify the Expr module.

Burnleydev1 · 2023-03-16T07:56:17Z

I'm sorry, Please @pitag-ha, @ceastlund, could you review the changes?

ceastlund · 2023-03-16T14:36:33Z

Looks pretty good. I think the two things missing are running dune fmt to re-ocamlformat the files, and signing off your commits. You can do that with git rebase --signoff.

Burnleydev1 · 2023-03-16T15:02:45Z

Thanks @ceastlund, I just implemented it now.

Signed-off-by: Burnleydev1 <[email protected]>

…he ast Signed-off-by: Burnleydev1 <[email protected]>

Signed-off-by: Burnleydev1 <[email protected]>

panglesd

Looks good, thanks @Burnleydev1!

panglesd · 2023-03-21T07:02:46Z

Could you add an entry to the changelog describing what you've done? Maybe focus on the user implications: multiple errors are now reported in metaquot!

Co-authored-by: panglesd <[email protected]> Signed-off-by: Burnleydev1 <[email protected]>

Burnleydev1 · 2023-03-21T07:53:15Z

Thanks @panglesd, I have updated the changelog message.

panglesd · 2023-03-21T08:28:57Z

Sorry, I meant can you update the file named CHANGES.md at the root of ppxlib sources (this one) to add an entry in the unreleased section?

Thanks!

Signed-off-by: Burnleydev1 <[email protected]>

Burnleydev1 · 2023-03-21T08:45:11Z

I'm sorry @panglesd, when I save my changes, all the ------------------ changes to ---, even though i did not change it.

Burnleydev1 · 2023-03-21T08:45:25Z

I am trying to fix it now

Signed-off-by: Burnleydev1 <[email protected]>

Burnleydev1 · 2023-03-21T08:56:58Z

Hello @panglesd, I think I fixed it, it was VScode deleting the extra - whenever I tried saving, I used text edit to make my changes and I think it is fine now.

Signed-off-by: Burnleydev1 <[email protected]>

panglesd · 2023-03-22T11:30:42Z

Thanks a lot for the contribution!

@pitag-ha

CHANGES: - Adopt the OCaml Code of Conduct on the repo (ocaml-ppx/ppxlib#426, @pitag-ha) - Clean up misleading attribute hints when declared for proper context. (ocaml-ppx/ppxlib#425, @ceastlund) - Ast_pattern now has ebool, pbool helper, and a new map.(ocaml-ppx/ppxlib#402, @Burnleydev1) - multiple errors are now reported in `metaquot`. (ocaml-ppx/ppxlib#397, @Burnleydev1) - Add `Attribute.declare_with_attr_loc` (ocaml-ppx/ppxlib#396, @dvulakh) - Add "ns" and "res" as reserved namespaces(ocaml-ppx/ppxlib#388, @davesnx) - Make quoter `let` binding non-recursive (ocaml-ppx/ppxlib#401, @sim642) - Fix failure of 'lift_map_with_context' in traverse by compile-time evaluation of 'fst' and 'snd' (ocaml-ppx/ppxlib#390, @smuenzel) - Driver: Bias the mapping from magic to version towards the current version, as it is usually the common case and it helps when magic numbers are ambiguous (such as on development versions) (ocaml-ppx/ppxlib#409, @shym) - Remove unnecessary test dependencies towards base and stdio (ocaml-ppx/ppxlib#421, @kit-ty-kate) - Update description to reflect that `ppxlib` contains more than a library (ocaml-ppx/ppxlib#422, @pitag-ha) - Add support for OCaml 5.1, excluding OCaml `5.1.0~alpha1` (ocaml-ppx/ppxlib#428, @shym, @Octachron , @pitag-ha, @panglesd) - Driver: Fix `-locations-check` option for coercions with ground (ocaml-ppx/ppxlib#428, @Octachron)

@pitag-ha

CHANGES: - Adopt the OCaml Code of Conduct on the repo (ocaml-ppx/ppxlib#426, @pitag-ha) - Clean up misleading attribute hints when declared for proper context. (ocaml-ppx/ppxlib#425, @ceastlund) - Ast_pattern now has ebool, pbool helper, and a new map.(ocaml-ppx/ppxlib#402, @Burnleydev1) - multiple errors are now reported in `metaquot`. (ocaml-ppx/ppxlib#397, @Burnleydev1) - Add `Attribute.declare_with_attr_loc` (ocaml-ppx/ppxlib#396, @dvulakh) - Add "ns" and "res" as reserved namespaces(ocaml-ppx/ppxlib#388, @davesnx) - Make quoter `let` binding non-recursive (ocaml-ppx/ppxlib#401, @sim642) - Fix failure of 'lift_map_with_context' in traverse by compile-time evaluation of 'fst' and 'snd' (ocaml-ppx/ppxlib#390, @smuenzel) - Driver: Bias the mapping from magic to version towards the current version, as it is usually the common case and it helps when magic numbers are ambiguous (such as on development versions) (ocaml-ppx/ppxlib#409, @shym) - Remove unnecessary test dependencies towards base and stdio (ocaml-ppx/ppxlib#421, @kit-ty-kate) - Update description to reflect that `ppxlib` contains more than a library (ocaml-ppx/ppxlib#422, @pitag-ha) - Add support for OCaml 5.1, excluding OCaml `5.1.0~alpha1` (ocaml-ppx/ppxlib#428, @shym, @Octachron , @pitag-ha, @panglesd) - Driver: Fix `-locations-check` option for coercions with ground (ocaml-ppx/ppxlib#428, @Octachron)

@pitag-ha

CHANGES: - Adopt the OCaml Code of Conduct on the repo (ocaml-ppx/ppxlib#426, @pitag-ha) - Clean up misleading attribute hints when declared for proper context. (ocaml-ppx/ppxlib#425, @ceastlund) - Ast_pattern now has ebool, pbool helper, and a new map.(ocaml-ppx/ppxlib#402, @Burnleydev1) - multiple errors are now reported in `metaquot`. (ocaml-ppx/ppxlib#397, @Burnleydev1) - Add `Attribute.declare_with_attr_loc` (ocaml-ppx/ppxlib#396, @dvulakh) - Add "ns" and "res" as reserved namespaces(ocaml-ppx/ppxlib#388, @davesnx) - Make quoter `let` binding non-recursive (ocaml-ppx/ppxlib#401, @sim642) - Fix failure of 'lift_map_with_context' in traverse by compile-time evaluation of 'fst' and 'snd' (ocaml-ppx/ppxlib#390, @smuenzel) - Driver: Bias the mapping from magic to version towards the current version, as it is usually the common case and it helps when magic numbers are ambiguous (such as on development versions) (ocaml-ppx/ppxlib#409, @shym) - Remove unnecessary test dependencies towards base and stdio (ocaml-ppx/ppxlib#421, @kit-ty-kate) - Update description to reflect that `ppxlib` contains more than a library (ocaml-ppx/ppxlib#422, @pitag-ha) - Add support for OCaml 5.1, excluding OCaml `5.1.0~alpha1` (ocaml-ppx/ppxlib#428, @shym, @Octachron , @pitag-ha, @panglesd) - Driver: Fix `-locations-check` option for coercions with ground (ocaml-ppx/ppxlib#428, @Octachron)

Burnleydev1 mentioned this pull request Mar 15, 2023

Metaquot: Embed errors in the AST instead of raising #392

Closed

Burnleydev1 changed the title ~~Metaquot: Embed errors in the AST~~ Metaquot: Embed errors in the AST instead of raising Mar 15, 2023

panglesd requested changes Mar 15, 2023

View reviewed changes

Comment thread metaquot/ppxlib_metaquot.ml Outdated

Burnleydev1 marked this pull request as ready for review March 16, 2023 07:50

Burnleydev1 requested review from ceastlund and pitag-ha as code owners March 16, 2023 07:50

Burnleydev1 requested review from panglesd and removed request for ceastlund and pitag-ha March 16, 2023 07:53

Burnleydev1 force-pushed the embedded_errors branch 3 times, most recently from 65f3c45 to 9e3d669 Compare March 16, 2023 15:52

Burnleydev1 added 5 commits March 16, 2023 16:55

minor changes

fc717ec

Signed-off-by: Burnleydev1 <[email protected]>

Added some code to change the error from raising to embedding it in t…

1611a02

…he ast Signed-off-by: Burnleydev1 <[email protected]>

remove function that contains error rasing in the previous fix

02fa1d5

Signed-off-by: Burnleydev1 <[email protected]>

added changes for

de338b5

Signed-off-by: Burnleydev1 <[email protected]>

did formating of the code using

389e05a

Signed-off-by: Burnleydev1 <[email protected]>

Burnleydev1 force-pushed the embedded_errors branch from 9e3d669 to 389e05a Compare March 16, 2023 15:57

panglesd approved these changes Mar 16, 2023

View reviewed changes

Comment thread metaquot/ppxlib_metaquot.ml Outdated

Burnleydev1 force-pushed the embedded_errors branch from b4aad6f to 265b8ea Compare March 16, 2023 20:43

multiple errors are now reported in metaquot

79e1f81

Co-authored-by: panglesd <[email protected]> Signed-off-by: Burnleydev1 <[email protected]>

Burnleydev1 force-pushed the embedded_errors branch from 265b8ea to 79e1f81 Compare March 21, 2023 07:47

edited changelog to describe changes made

1b47093

Signed-off-by: Burnleydev1 <[email protected]>

edited changelog to describe changes made

1c371ec

Signed-off-by: Burnleydev1 <[email protected]>

Burnleydev1 added 2 commits March 21, 2023 10:03

Merge branch 'main' into embedded_errors

f8fb918

removed spacings included in previous changes.

31eb192

Signed-off-by: Burnleydev1 <[email protected]>

Burnleydev1 force-pushed the embedded_errors branch from 9b78aa1 to 31eb192 Compare March 22, 2023 11:25

panglesd merged commit f7035cd into ocaml-ppx:main Mar 22, 2023

tmattio mentioned this pull request Jun 20, 2023

[new release] ppxlib and ppxlib-bench (0.30.0) ocaml/opam-repository#23965

Merged

Uh oh!

Conversation

Burnleydev1 commented Mar 15, 2023

Uh oh!

panglesd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Burnleydev1 commented Mar 16, 2023

Uh oh!

ceastlund commented Mar 16, 2023

Uh oh!

Burnleydev1 commented Mar 16, 2023

Uh oh!

panglesd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

panglesd commented Mar 21, 2023

Uh oh!

Burnleydev1 commented Mar 21, 2023

Uh oh!

panglesd commented Mar 21, 2023

Uh oh!

Burnleydev1 commented Mar 21, 2023

Uh oh!

Burnleydev1 commented Mar 21, 2023

Uh oh!

Burnleydev1 commented Mar 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

panglesd commented Mar 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Burnleydev1 commented Mar 21, 2023 •

edited

Loading