Use effect syntax for OCaml 5.3#42
Merged
Merged
Conversation
Also fix the dynamic_state example which was disabled previously and hook it back into the Makefile
Contributor
Author
|
This is expected to fail in ocaml-ci until ocaml/ocaml#12309 is merged. You can try it out quickly by using |
dhil
approved these changes
May 8, 2024
dhil
left a comment
dhil
left a comment
Collaborator
There was a problem hiding this comment.
LFTM (looks familiar to me).
Collaborator
Do you want me to prepare a new release? |
Contributor
Author
|
@dhil a new release would be great! I think it's dhil/ocaml-multicont#8 that is the problem, and you've merged that into your development tree. |
Contributor
Author
|
It's green now in CI so I've gone ahead and merged this, and also added a note to the README that users who want a pre-effect-syntax can use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This currently needs ocaml/ocaml#12309 (soon to be merged) and
opam pin add multicont --devas that also fails to compile with the released version.