Remove unused symbols (and remove symbol_scoping)#556
Closed
Gbury wants to merge 9 commits intoocaml-flambda:flambda2.0-stablefrom
Closed
Remove unused symbols (and remove symbol_scoping)#556Gbury wants to merge 9 commits intoocaml-flambda:flambda2.0-stablefrom
Gbury wants to merge 9 commits intoocaml-flambda:flambda2.0-stablefrom
Conversation
Gbury
changed the title
mshinwell
force-pushed
the
dominator_split
branch
from
2f9832f to
d3b6d63
Compare
|
Review is in progress |
Avoid risk of further refactor from breaking symbol dependency tracking
chambart
force-pushed
the
dominator_split
branch
from
34476fb to
8c994bc
Compare
mshinwell
pushed a commit
to oxcaml/oxcaml
that referenced
this pull request
Aug 18, 2021
basimkhajwal
pushed a commit
to basimkhajwal/flambda-backend
that referenced
this pull request
Sep 10, 2021
poechsel
pushed a commit
to oxcaml/oxcaml
that referenced
this pull request
Sep 20, 2021
|
Done in the Flambda backend repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased version of #535 . It's not very convenient to try and split it further considering that the data flow analysis is correct if and only if it is used (i.e. if some names are deemed unused by the analysis but not effectively removed, it's unsafe). However, the changes are split into two different commits which may be easier to review separately.