Skip to content

Remove unused dominator symbols#535

Closed
Gbury wants to merge 3 commits intoocaml-flambda:flambda2.0-stablefrom
Gbury:dominator_symbols_rdy
Closed

Remove unused dominator symbols#535
Gbury wants to merge 3 commits intoocaml-flambda:flambda2.0-stablefrom
Gbury:dominator_symbols_rdy

Conversation

@Gbury
Copy link

@Gbury Gbury commented Jul 5, 2021

This PR does a few things:

  • add to data_flow the analysis of which code_id and symbols are used (taking into account the closure_vars)
  • use the result of this analysis to remove unused code_ids and symbols
  • remove the distinction between syntactic and dominator symbols, given that the data_flow analysis apply to both
  • refine the data_flow analysis dependency in the case of Apply_exprs to use the free_name after simplification (instead of before simplification)

This should be good to review.

Gbury added 3 commits July 2, 2021 15:26
@Gbury
Use dominator scope for all symbols
97eeffa 
Data_flow now records the dependencies on code_ids,
closure_vars and symbols, and is now able to compute
unused information on symbols and code_ids.
The Syntactic scoep for symbols is removed, given that
dominator symbols can now be removed using the data_flow
check.
@Gbury
Cleanup
fd2bc27
@Gbury
Some more cleanup to reduce the diff
68880ee
@Gbury Gbury mentioned this pull request Jul 12, 2021
Closed
@Gbury
Copy link
Author

Gbury commented Jul 12, 2021

Closing in favour of #556

@Gbury Gbury closed this Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Gbury