Use extcalls for bound errors#168
Merged
Gbury merged 8 commits intoflambda2.0-stablefrom Jun 26, 2020
Merged
Conversation
lthls
reviewed
Jun 17, 2020
lthls
reviewed
Jun 19, 2020
Gbury
force-pushed
the
bound_error
branch
2 times, most recently
from
43a5e90 to
38c1613
Compare
Author
|
History has been cleaned up, better reviewed commit by commit. Note that the |
|
The explicit |
Also remove deadcode after a call to caml_ml_array_bound_error
lthls
reviewed
Jun 24, 2020
lthls
reviewed
Jun 24, 2020
lthls
reviewed
Jun 24, 2020
lthls
reviewed
Jun 24, 2020
lthls
reviewed
Jun 24, 2020
lthls
reviewed
Jun 24, 2020
lthls
added a commit
that referenced
this pull request
Sep 29, 2020
* Allow application that never return + shorten out_of_bound raise * Turn cmm.extcall tuple into a record * Properly handle never returning functions in the backend Also remove deadcode after a call to caml_ml_array_bound_error * Review * Bettre code factorization * Refactor back some duplicated code * Update apply_expr.ml * typo Co-authored-by: Vincent Laviron <[email protected]>
This was referenced Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the code for out of bounds error: previously it raise manually an exception (and had to create the exn). Now it can call the dedicated c function to raise the exception. This change could probably be dependant on a compiler option ?
Additionally to the primitive translation part of the changes, 2 additional changes are present:
caml_ml_array_bound_errorin the same way as tailcalls.