Skip to content

Update core_kernel and dependencies #208

Merged
toots merged 9 commits intoocaml-cross:masterfrom
WardBrian:update-core
Nov 2, 2021
Merged

Update core_kernel and dependencies #208
toots merged 9 commits intoocaml-cross:masterfrom
WardBrian:update-core

Conversation

@WardBrian
Copy link
Copy Markdown
Collaborator

Similar to #207, this compiles locally but the docker instance has unrelated issues and fails before testing starts.

My apologies for all the changes at once, I didn't realize just how deep the dependency trees went. I'm happy to split it up if desired, the end goal was simply to update core_kernel to 0.14.2

@WardBrian
Copy link
Copy Markdown
Collaborator Author

I should note these should be compatible with 4.11 as well, so they aren't dependent on #206

@WardBrian
Copy link
Copy Markdown
Collaborator Author

Sorry about the missed dep. I think it will work this time (It got through installing the really big dependency-havers before failing the first time)

@WardBrian
Copy link
Copy Markdown
Collaborator Author

I think I can run the CI locally now so I'm trying that before pushing the fix - there are a few other brand-new packages in this PR that I want to make sure I found all the dependencies for

@WardBrian
Copy link
Copy Markdown
Collaborator Author

This now passes everything locally for me in the docker instance.

@WardBrian
Copy link
Copy Markdown
Collaborator Author

It seems like the 6 hour time limit cut off the x64 test right before it was going to finish. Do I need to split this PR?

Copy link
Copy Markdown
Member

@toots toots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passed one of the two architectures, I believe that this is enough. Thanks for the hard work!

@toots toots merged commit a3341b2 into ocaml-cross:master Nov 2, 2021
@WardBrian WardBrian deleted the update-core branch November 2, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants