Skip to content

Disable warn-error, as it makes developing on a trunk compiler hard#1367

Merged
samoht merged 1 commit intoocaml:masterfrom
avsm:no-warn-error
May 1, 2014
Merged

Disable warn-error, as it makes developing on a trunk compiler hard#1367
samoht merged 1 commit intoocaml:masterfrom
avsm:no-warn-error

Conversation

@avsm
Copy link
Member

@avsm avsm commented May 1, 2014

This is currently blocking the upstream ocaml/ocaml Travis tests from passing on trunk, since we:

  • have to use OPAM trunk (since ocp-build doesnt work on 4.02)
  • have new errors (deprecation warnings) that shouldn't be fatal

Disabling -warn-error and keeping an eye out for errors during normal development is vastly preferable...

@avsm
Copy link
Member Author

avsm commented May 1, 2014

@samoht
Copy link
Member

samoht commented May 1, 2014

Blocked on #1336 ... need we're missing a version constraint in the dose/cudf packages

samoht added a commit that referenced this pull request May 1, 2014
Disable warn-error, as it makes developing on a trunk compiler hard
@samoht samoht merged commit 4f43862 into ocaml:master May 1, 2014
@samoht
Copy link
Member

samoht commented May 1, 2014

Would be nice to have an option to enable a Travis CI with the full option though.

@avsm avsm deleted the no-warn-error branch May 1, 2014 16:12
@avsm
Copy link
Member Author

avsm commented May 1, 2014

It's possible to have a 'allowed failure' in Travis that could be appropriate for this.

@samoht
Copy link
Member

samoht commented May 1, 2014

(or to easily enable this when developping opam, ie. some Makefile or env variable tweaks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants