PR#7172: ocamlc -config: add int_size, word_size, natdynlink, ext_exe#970
PR#7172: ocamlc -config: add int_size, word_size, natdynlink, ext_exe#970gasche merged 1 commit intoocaml:trunkfrom
Conversation
Makefile
Outdated
| -e 's|%%ARCH%%|$(ARCH)|' \ | ||
| -e 's|%%MODEL%%|$(MODEL)|' \ | ||
| -e 's|%%SYSTEM%%|$(SYSTEM)|' \ | ||
| -e 's|%%EXT_EXE%%||' \ |
There was a problem hiding this comment.
I'm fairly sure this logic isn't correct - Cygwin should have .exe and possibly also Linux cross-compiling using mingw? (both of which use configure, not Makefile.nt)
There was a problem hiding this comment.
That's a good point, I'll change it to be whatever configure decided it would use for the installed binaries.
|
The "proper" way would be to alter configure so that native code compilation becomes effectively part of make world (i.e. no opt or opt.opt stages) but that would require a lot of care for bootstrapping, I think (though possibly no more than requiring one to disable native code compilation via configure specifically when bootstrapping). One for @shindere, I expect! A more compatible, though time-consuming, way would be to alter config.mlp during |
|
Actually, a third possibility for compatibility would be to have |
gasche
force-pushed
the
extend-ocamlc-configure
branch
2 times, most recently
from
2d41101 to
9e68432
Compare
|
I think your last suggestion is excellent, but I would like to keep |
|
Could we keep |
|
This is a reasonable argument, so I removed |
gasche
force-pushed
the
extend-ocamlc-configure
branch
from
9e68432 to
c6fea83
Compare
|
This (unsurprisingly) all looks fine - anything to add, @dbuenzli? Merge once the CI confirms? I'm happy to be assigned the rest of PR to be ready for 4.05, unless you have a burning desire to do it? It would be good (both philosophically and practically) not to be relying on tools such as OPAM to determine the installed state of the compiler. |
|
Thanks, I went ahead and merged. I don't plan on working on the rest of the PR before 4.05, so you should feel free to do so if you wish. (Also I'm not comfortable hacking on the build system and I entertain the wishful thought that others such as you may enjoy it more.) That said, please be aware that this mantis issue is not high-priority, it's a nice-to-have: feel free to assign yourself for task-tracking purposes, but don't feel bad if you slip the 4.05 deadline. |
|
David Allsopp (2016/12/14 03:47 -0800):
The "proper" way would be to alter configure so that native code
compilation becomes effectively part of make world (i.e. no opt or
opt.opt stages) but that would require a lot of care for
bootstrapping, I think (though possibly no more than requiring one to
disable native code compilation via configure specifically when
bootstrapping). One for @shindere, I expect!
Yes. I think ultimately make should have a default target that builds
what configure has detected can be built, so that one can use the usual
./configure && make && make install paradigm.
Does that look reasonable?
|
|
The only question is what happens if a bootstrap cycle is required? |
|
Re
@gasche As you mentioned you need a configuration variable to disable the construction of native code compilers for that.
I think we can reasonably devise a system where what you configure to be built coincides with what the default install procedure will install.
Or not, you may be only interested in e.g. compiler-libs libraries. Checking for binaries is very brittle. For example checking the availability of FWIW to determine this I currently check for the availability of |
|
Regarding the brittleness - the ocaml autoconf macros also check that ocamlopt and ocamlc use the same standard library directory. Though this is not perfect (OCAMLLIB can get in the way here), it does help eliminate the real problem of ocamlopt being detected from a different ocaml installation. You could, with excessive paranoia, also check that, say, pervasives.cmi has the correct magic numbers for the compiler. |
|
|
||
| - PR#7172, GPR#970: add extra (ocamlc -config) options | ||
| int_size, word_size, ext_exe | ||
| (Gabriel Scherer, request by Daniel Buenzli) |
There was a problem hiding this comment.
Gabriel, you have lost Mr. Bünzli's umlaut. I guess he's too modest to complain. Once I sign the CLA, I'll fix this sacrilege.
There was a problem hiding this comment.
You don't need a CLA for tiny changes!
However, it's not lost - ue is a permitted alternative (note Daniel's GitHub handle)
There was a problem hiding this comment.
I actually like umlaüten, so Bünzli is the spelling I tend to use, no idea why this one was different. There are also two clearly wrong "Bunzli" in the Changes file (I think it is Alain's fault), so we could do a pass to harmonize this. I'll have a look at whether other names should be fixed as well.
There was a problem hiding this comment.
I've fixed several here (including this one): 7dc4993.
There was a problem hiding this comment.
Well, getting useful commits stuck in an ambitious pull request is bad. I can cherry-pick and go from there -- I just did a pass on the Changelog.
There was a problem hiding this comment.
In fact your commit is tangled with a Changes entry, so I won't cherry-pick it -- I had done the same changes independently, plus some.
…ore with flambda2 (ocaml#970)
b11eea1 flambda-backend: Introduce Import_info (ocaml#1036) bc5b135 flambda-backend: Fix `ocamlobjinfo` on flambda2 .cmx files (ocaml#1029) c8babbd flambda-backend: Compilation_unit optimisations (ocaml#1035) e8d3e22 flambda-backend: Use 4.14.0 opam switch for building (includes upgrading ocamlformat to 0.24.1) (ocaml#1030) eb14a86 flambda-backend: Port PR81 from ocaml-jst (ocaml#1024) 131bc12 flambda-backend: Merge ocaml-jst 2022-12-13 (ocaml#1022) 06c189a flambda-backend: Make stack allocation the default (ocaml#1013) 98debd5 flambda-backend: Initial support for value slots not of value kind (ocaml#946) deb1714 flambda-backend: Add is_last flag to closinfo words (ocaml#938) d07fce1 flambda-backend: Disable poll insertion in Configure (ocaml#967) 0f1ce0e flambda-backend: Regenerate ocaml/configure autoconf 2.69 (instead of 2.71) (ocaml#1012) 27132d8 flambda-backend: Fix for spurious typing error related to expanding through functor arguments (ocaml#997) 724fb68 flambda-backend: Use `Compilation_unit.t` instead of `Ident.t` for globals (ocaml#871) 396d5b8 flambda-backend: Add a test for frametable setup in natdynlinked libraries (ocaml#983) b73ab12 flambda-backend: Fix invocation of `caml_shared_startup` in native dynlink (ocaml#980) 7c7d75a flambda-backend: Fix split_default_wrapper which did not trigger anymore with flambda2 (ocaml#970) 8fb75bd flambda-backend: Port ocaml#11727 and ocaml#11732 (ocaml#965) fdb7987 flambda-backend: Fix include functor issue after 4.14 merge. (ocaml#948) 9745cdb flambda-backend: Print -dprofile/-dtimings output to stdout like 4.12 (ocaml#943) 5f51f21 flambda-backend: Merge pull request ocaml#932 from mshinwell/4.14-upgrade 841687d flambda-backend: Run make alldepend in ocaml/ (ocaml#936) 72a7658 flambda-backend: Remove reformatting changes only in dynlink/dune (preserving PR889 and adjusting to minimise diff) 6d758cd flambda-backend: Revert whitespace changes in dune files, to match upstream c86bf6e flambda-backend: Remove duplicate tests for polling 971dbeb flambda-backend: Testsuite fixes 32f8356 flambda-backend: Topeval fix for symbols patch befea01 flambda-backend: Compilation fixes / rectify merge faults a84543f flambda-backend: Merge ocaml-jst 8e65056 flambda-backend: Merge ocaml-jst 4d70045 flambda-backend: Remove filename from system frametable (amd64) (ocaml#920) 5e57b7d flambda-backend: Bugfix for runtime frame_descr logic for C frames (ocaml#918) 6423d5e flambda-backend: Merge pull request ocaml#914 from mshinwell/merge-ocaml-jst-2022-10-24 ead605c flambda-backend: Add a missing Extract_exception (ocaml#916) c8f1481 flambda-backend: Resolve conflicts and add specialise/specialised attributes to Builtin_attributes cf4d0d3 flambda-backend: Merge fixes (ocaml#21) c2f742f flambda-backend: Re-enable some tests for Flambda2 (ocaml#881) 3d38d13 flambda-backend: Long frames in frametable (ocaml#797) 85aec7b flambda-backend: Add loop attribute to Builtin_attributes c0f16e3 flambda-backend: Compilation fixes 90dea23 flambda-backend: Merge flambda-backend/main 5acc6ea flambda-backend: Fixes after merge e501946 flambda-backend: Merge ocaml-jst 115083b flambda-backend: Merge ocaml-jst 9943b2e flambda-backend: Revert "Revert "Transform tail-recursive functions into recursive continuations (ocaml#893)"" (ocaml#909) ce339f1 flambda-backend: Fix alloc modes and call kinds for overapplications (ocaml#902) e6a317c flambda-backend: Revert "Transform tail-recursive functions into recursive continuations (ocaml#893)" 853c488 flambda-backend: Transform tail-recursive functions into recursive continuations (ocaml#893) 5a977e4 flambda-backend: Fix missing End_region primitives on switch arms (ocaml#898) 7fa7f9d flambda-backend: Add missing dependencies to Dune files (ocaml#889) 3cd36f0 flambda-backend: Have Lambda `Pgetglobal` and `Psetglobal` take `Compilation_unit.t` (ocaml#896) 7565915 flambda-backend: [@poll error] attribute (ocaml#745) 9eb9448 flambda-backend: Backport the main safepoints PRs (ocaml#740) 689bdda flambda-backend: Add strict mode for ocamldep (ocaml#892) git-subtree-dir: ocaml git-subtree-split: b11eea1
* Add outreachy video field * Add links to videos --------- Co-authored-by: Cuihtlauac ALVARADO <[email protected]>
5 participants
See MPR#7172.
Among the options that @dbuenzli asked, one that is not included is "nativecomp", which he specified as "whether native compilation is available". First, I'm not completely sure how to implement that (there is no obvious makefile variable I can reuse), and second it is unclear to me that we actually can give it a specification:
config.mlptells about how the compiler distribution was configured to be built, but not about what was actually installed on the user machine, so while I can say if native-compilation was disabled at configure-time, if I saytrueat config-time you still have to check thatocamloptis actually installed to be sure.