Fix evaluation order for overapplications when using Closure#967
Merged
mshinwell merged 4 commits intoocaml:trunkfrom Dec 29, 2016
Merged
Fix evaluation order for overapplications when using Closure#967mshinwell merged 4 commits intoocaml:trunkfrom
mshinwell merged 4 commits intoocaml:trunkfrom
Conversation
Contributor
It would be useful to see the impact on performance, even on some micro-benchmarks only. Evaluating extra arguments before the call is likely to create more transit with the memory. |
yallop
reviewed
Dec 13, 2016
| (Jeremy Yallop) | ||
|
|
||
| - GPR#967, PR#6536: Fix Closure so that overapplication evaluation order | ||
| matches the bytecode compiler and Flambda. |
Member
There was a problem hiding this comment.
The Mantis PR number should be 6136, not 6536. It's also conventional to list the author and the reporter.
Contributor
|
Over-applications are exceedingly rare in practice, so I'm not too worried about a performance degradation here. |
Contributor
Author
|
I also think the rarity of these cases means that we shouldn't really be worrying about the performance impact of this change. Furthermore, constructing benchmarks that actually give meaningful results for changes like this probably isn't entirely straightforward, and given limited time I think our attention is best concentrated elsewhere (e.g. #966). Would anyone like to comment on the correctness of this patch? |
Contributor
Author
|
@let-def I nominate you to review. :) |
Contributor
|
This looks good to me. I was wondering if there was an interest in forcing evaluation order of all arguments instead of only over-applied ones (folding only on rem_args), but I don't think this change anything in practice. |
Contributor
Author
|
Modulo any problems in the backend, of course, but we're addressing those in a different GPR. Thanks for the review, I will merge this. |
camlspotter
pushed a commit
to camlspotter/ocaml
that referenced
this pull request
Oct 17, 2017
This was referenced Mar 14, 2019
sadiqj
pushed a commit
to sadiqj/ocaml
that referenced
this pull request
Feb 21, 2023
Add configure option --enable-poll-insertion Use the new configure option Add -enable-poll-insertion compilation flag Fix tests ocaml/configure updated Add --enable-poll-insertion to CI Add to build_ocaml_compiler.sexp Remove CR (it's done by this PR) Use Config.poll_insertion to set the default for the compile flag
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Mar 21, 2023
Add configure option --enable-poll-insertion Use the new configure option Add -enable-poll-insertion compilation flag Fix tests ocaml/configure updated Add --enable-poll-insertion to CI Add to build_ocaml_compiler.sexp Remove CR (it's done by this PR) Use Config.poll_insertion to set the default for the compile flag
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Mar 21, 2023
b11eea1 flambda-backend: Introduce Import_info (ocaml#1036) bc5b135 flambda-backend: Fix `ocamlobjinfo` on flambda2 .cmx files (ocaml#1029) c8babbd flambda-backend: Compilation_unit optimisations (ocaml#1035) e8d3e22 flambda-backend: Use 4.14.0 opam switch for building (includes upgrading ocamlformat to 0.24.1) (ocaml#1030) eb14a86 flambda-backend: Port PR81 from ocaml-jst (ocaml#1024) 131bc12 flambda-backend: Merge ocaml-jst 2022-12-13 (ocaml#1022) 06c189a flambda-backend: Make stack allocation the default (ocaml#1013) 98debd5 flambda-backend: Initial support for value slots not of value kind (ocaml#946) deb1714 flambda-backend: Add is_last flag to closinfo words (ocaml#938) d07fce1 flambda-backend: Disable poll insertion in Configure (ocaml#967) 0f1ce0e flambda-backend: Regenerate ocaml/configure autoconf 2.69 (instead of 2.71) (ocaml#1012) 27132d8 flambda-backend: Fix for spurious typing error related to expanding through functor arguments (ocaml#997) 724fb68 flambda-backend: Use `Compilation_unit.t` instead of `Ident.t` for globals (ocaml#871) 396d5b8 flambda-backend: Add a test for frametable setup in natdynlinked libraries (ocaml#983) b73ab12 flambda-backend: Fix invocation of `caml_shared_startup` in native dynlink (ocaml#980) 7c7d75a flambda-backend: Fix split_default_wrapper which did not trigger anymore with flambda2 (ocaml#970) 8fb75bd flambda-backend: Port ocaml#11727 and ocaml#11732 (ocaml#965) fdb7987 flambda-backend: Fix include functor issue after 4.14 merge. (ocaml#948) 9745cdb flambda-backend: Print -dprofile/-dtimings output to stdout like 4.12 (ocaml#943) 5f51f21 flambda-backend: Merge pull request ocaml#932 from mshinwell/4.14-upgrade 841687d flambda-backend: Run make alldepend in ocaml/ (ocaml#936) 72a7658 flambda-backend: Remove reformatting changes only in dynlink/dune (preserving PR889 and adjusting to minimise diff) 6d758cd flambda-backend: Revert whitespace changes in dune files, to match upstream c86bf6e flambda-backend: Remove duplicate tests for polling 971dbeb flambda-backend: Testsuite fixes 32f8356 flambda-backend: Topeval fix for symbols patch befea01 flambda-backend: Compilation fixes / rectify merge faults a84543f flambda-backend: Merge ocaml-jst 8e65056 flambda-backend: Merge ocaml-jst 4d70045 flambda-backend: Remove filename from system frametable (amd64) (ocaml#920) 5e57b7d flambda-backend: Bugfix for runtime frame_descr logic for C frames (ocaml#918) 6423d5e flambda-backend: Merge pull request ocaml#914 from mshinwell/merge-ocaml-jst-2022-10-24 ead605c flambda-backend: Add a missing Extract_exception (ocaml#916) c8f1481 flambda-backend: Resolve conflicts and add specialise/specialised attributes to Builtin_attributes cf4d0d3 flambda-backend: Merge fixes (ocaml#21) c2f742f flambda-backend: Re-enable some tests for Flambda2 (ocaml#881) 3d38d13 flambda-backend: Long frames in frametable (ocaml#797) 85aec7b flambda-backend: Add loop attribute to Builtin_attributes c0f16e3 flambda-backend: Compilation fixes 90dea23 flambda-backend: Merge flambda-backend/main 5acc6ea flambda-backend: Fixes after merge e501946 flambda-backend: Merge ocaml-jst 115083b flambda-backend: Merge ocaml-jst 9943b2e flambda-backend: Revert "Revert "Transform tail-recursive functions into recursive continuations (ocaml#893)"" (ocaml#909) ce339f1 flambda-backend: Fix alloc modes and call kinds for overapplications (ocaml#902) e6a317c flambda-backend: Revert "Transform tail-recursive functions into recursive continuations (ocaml#893)" 853c488 flambda-backend: Transform tail-recursive functions into recursive continuations (ocaml#893) 5a977e4 flambda-backend: Fix missing End_region primitives on switch arms (ocaml#898) 7fa7f9d flambda-backend: Add missing dependencies to Dune files (ocaml#889) 3cd36f0 flambda-backend: Have Lambda `Pgetglobal` and `Psetglobal` take `Compilation_unit.t` (ocaml#896) 7565915 flambda-backend: [@poll error] attribute (ocaml#745) 9eb9448 flambda-backend: Backport the main safepoints PRs (ocaml#740) 689bdda flambda-backend: Add strict mode for ocamldep (ocaml#892) git-subtree-dir: ocaml git-subtree-split: b11eea1
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the Closure pass (i.e. non-Flambda) the evaluation order for overapplications does not match the bytecode compiler and Flambda: as shown by PR#6136, the subset of arguments forming the full application are evaluated first, then the function is called; and then the remaining arguments are evaluated. This patch fixes that by let-binding the arguments before the call.