Skip to content

INSTALL.adoc: explain why configure looks for the curses library.#909

Merged
gasche merged 1 commit intoocaml:trunkfrom
adrien-n:document-the-use-for-curses
Nov 11, 2016
Merged

INSTALL.adoc: explain why configure looks for the curses library.#909
gasche merged 1 commit intoocaml:trunkfrom
adrien-n:document-the-use-for-curses

Conversation

@adrien-n
Copy link
Contributor

Hint: it is used in the toplevel to highlight errors using something nicer
than a bunch of (slightly-misaligned) '^' on a new line.

NB: $curseslibs ends up in $BYTECCLIBS and we probably link against curses
in the bytecode runtime while we only need it for the toplevel.

Hint: it is used in the toplevel to highlight errors using something nicer
than a bunch of (slightly-misaligned) '^' on a new line.

NB: $curseslibs ends up in $BYTECCLIBS and we probably link against curses
in the bytecode runtime while we only need it for the toplevel.
@gasche
Copy link
Member

gasche commented Nov 11, 2016

Fine with me. One information that could be present somewhere is the fact that, if the OCaml compiler distribution was built with ncurses enabled, then producing bytecode executables in -custom mode will have the resulting binary depend on ncurses as well -- see ocaml/opam-repository#6657.

@gasche gasche merged commit d7a5296 into ocaml:trunk Nov 11, 2016
@adrien-n
Copy link
Contributor Author

I hadn't thought of -custom.

I've added a comment on https://caml.inria.fr/mantis/view.php?id=6735 which is precisely on this issue. I might give it a try this week-end but otherwise anyone should feel free to submit a patch; only linking $curseslibs when also linking Terminfo shouldn't be too difficult nor require synchronization to avoid duplicate work.

@shindere
Copy link
Contributor

adrien-n (2016/11/11 13:52 -0800):

Hint: it is used in the toplevel to highlight errors using something nicer
than a bunch of (slightly-misaligned) '^' on a new line.

Regarding the slight mis-alignment. Is this something that would be worth a
Mantis ticket?

If such a ticket is created, perhaps it could contain an example
illustrating the problem, which could then be turned into a test and
added to the testsuite?
Or would that be overkill?

@adrien-n
Copy link
Contributor Author

On Sun, Nov 13, 2016, Sébastien Hinderer wrote:

adrien-n (2016/11/11 13:52 -0800):

Hint: it is used in the toplevel to highlight errors using something nicer
than a bunch of (slightly-misaligned) '^' on a new line.

Regarding the slight mis-alignment. Is this something that would be worth a
Mantis ticket?

If such a ticket is created, perhaps it could contain an example
illustrating the problem, which could then be turned into a test and
added to the testsuite?
Or would that be overkill?

I've not seen that often and pretty much always with really large
pastes, long lines and comments. At that point it becomes unreadable
anyway because the toplevel simply copies the faulty line and replaces
the faulty word with carets; for lines longer than your terminal width,
you get blank lines, everything is shifted upwards, you lose context.

The best solution is to stop using only the toplevel in a terminal and
switch to some kind of IDE or put the code in a .ml file because you can
then go to the proper line with your text editor.

IOW, I've mostly witnessed this when the amount and the complexity of
the code was already too much to cleanly display in the toplevel, even
without warnings or errors.

camlspotter pushed a commit to camlspotter/ocaml that referenced this pull request Oct 17, 2017
INSTALL.adoc: explain why configure looks for the curses library.
stedolan pushed a commit to stedolan/ocaml that referenced this pull request Oct 25, 2022
sadiqj pushed a commit to sadiqj/ocaml that referenced this pull request Feb 21, 2023
stedolan pushed a commit to stedolan/ocaml that referenced this pull request Mar 21, 2023
b11eea1 flambda-backend: Introduce Import_info (ocaml#1036)
bc5b135 flambda-backend: Fix `ocamlobjinfo` on flambda2 .cmx files (ocaml#1029)
c8babbd flambda-backend: Compilation_unit optimisations (ocaml#1035)
e8d3e22 flambda-backend: Use 4.14.0 opam switch for building (includes upgrading ocamlformat to 0.24.1) (ocaml#1030)
eb14a86 flambda-backend: Port PR81 from ocaml-jst (ocaml#1024)
131bc12 flambda-backend: Merge ocaml-jst 2022-12-13 (ocaml#1022)
06c189a flambda-backend: Make stack allocation the default (ocaml#1013)
98debd5 flambda-backend: Initial support for value slots not of value kind (ocaml#946)
deb1714 flambda-backend: Add is_last flag to closinfo words (ocaml#938)
d07fce1 flambda-backend: Disable poll insertion in Configure (ocaml#967)
0f1ce0e flambda-backend: Regenerate ocaml/configure autoconf 2.69 (instead of 2.71) (ocaml#1012)
27132d8 flambda-backend: Fix for spurious typing error related to expanding through functor arguments (ocaml#997)
724fb68 flambda-backend: Use `Compilation_unit.t` instead of `Ident.t` for globals (ocaml#871)
396d5b8 flambda-backend: Add a test for frametable setup in natdynlinked libraries (ocaml#983)
b73ab12 flambda-backend: Fix invocation of `caml_shared_startup` in native dynlink (ocaml#980)
7c7d75a flambda-backend: Fix split_default_wrapper which did not trigger anymore with flambda2 (ocaml#970)
8fb75bd flambda-backend: Port ocaml#11727 and ocaml#11732 (ocaml#965)
fdb7987 flambda-backend: Fix include functor issue after 4.14 merge. (ocaml#948)
9745cdb flambda-backend: Print -dprofile/-dtimings output to stdout like 4.12 (ocaml#943)
5f51f21 flambda-backend: Merge pull request ocaml#932 from mshinwell/4.14-upgrade
841687d flambda-backend: Run make alldepend in ocaml/ (ocaml#936)
72a7658 flambda-backend: Remove reformatting changes only in dynlink/dune (preserving PR889 and adjusting to minimise diff)
6d758cd flambda-backend: Revert whitespace changes in dune files, to match upstream
c86bf6e flambda-backend: Remove duplicate tests for polling
971dbeb flambda-backend: Testsuite fixes
32f8356 flambda-backend: Topeval fix for symbols patch
befea01 flambda-backend: Compilation fixes / rectify merge faults
a84543f flambda-backend: Merge ocaml-jst
8e65056 flambda-backend: Merge ocaml-jst
4d70045 flambda-backend: Remove filename from system frametable (amd64) (ocaml#920)
5e57b7d flambda-backend: Bugfix for runtime frame_descr logic for C frames (ocaml#918)
6423d5e flambda-backend: Merge pull request ocaml#914 from mshinwell/merge-ocaml-jst-2022-10-24
ead605c flambda-backend: Add a missing Extract_exception (ocaml#916)
c8f1481 flambda-backend: Resolve conflicts and add specialise/specialised attributes to Builtin_attributes
cf4d0d3 flambda-backend: Merge fixes (ocaml#21)
c2f742f flambda-backend: Re-enable some tests for Flambda2 (ocaml#881)
3d38d13 flambda-backend: Long frames in frametable (ocaml#797)
85aec7b flambda-backend: Add loop attribute to Builtin_attributes
c0f16e3 flambda-backend: Compilation fixes
90dea23 flambda-backend: Merge flambda-backend/main
5acc6ea flambda-backend: Fixes after merge
e501946 flambda-backend: Merge ocaml-jst
115083b flambda-backend: Merge ocaml-jst
9943b2e flambda-backend: Revert "Revert "Transform tail-recursive functions into recursive continuations (ocaml#893)"" (ocaml#909)
ce339f1 flambda-backend: Fix alloc modes and call kinds for overapplications (ocaml#902)
e6a317c flambda-backend: Revert "Transform tail-recursive functions into recursive continuations (ocaml#893)"
853c488 flambda-backend: Transform tail-recursive functions into recursive continuations (ocaml#893)
5a977e4 flambda-backend: Fix missing End_region primitives on switch arms (ocaml#898)
7fa7f9d flambda-backend: Add missing dependencies to Dune files (ocaml#889)
3cd36f0 flambda-backend: Have Lambda `Pgetglobal` and `Psetglobal` take `Compilation_unit.t` (ocaml#896)
7565915 flambda-backend: [@poll error] attribute (ocaml#745)
9eb9448 flambda-backend: Backport the main safepoints PRs (ocaml#740)
689bdda flambda-backend: Add strict mode for ocamldep (ocaml#892)

git-subtree-dir: ocaml
git-subtree-split: b11eea1
EmileTrotignon pushed a commit to EmileTrotignon/ocaml that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants