Install native versions of tools by default.#587
Merged
damiendoligez merged 1 commit intoocaml:trunkfrom Jun 7, 2016
Merged
Conversation
Closed
DemiMarie
force-pushed
the
native-by-default2
branch
from
6be7b06 to
1845a6e
Compare
tools/Makefile.shared
Outdated
| CAMLC=$(CAMLRUN) ../boot/ocamlc -nostdlib -I ../boot -use-prims ../byterun/primitives | ||
| CAMLOPT=$(CAMLRUN) ../ocamlopt -nostdlib -I ../stdlib | ||
| CAMLC=$(CAMLRUN) ../boot/ocamlc -nostdlib -I ../boot -use-prims \ | ||
| ../byterun/primitives -I .. |
Member
There was a problem hiding this comment.
Why do we need to add -I .. ? AFAICT, there shouldn't be any .cmi files in ..
Contributor
Author
There was a problem hiding this comment.
Many files are referred to by paths that are relative to .., if I remember correctly.
Member
There was a problem hiding this comment.
This -I .. is redundant with the one on line 54.
DemiMarie
force-pushed
the
native-by-default2
branch
from
b28f48a to
bc282b8
Compare
Previously, `ocamlc`, `ocamlopt`, `ocamllex`, and `ocamldep` defaulted to the bytecode versions of the tools. However, there is normally no advantage to the bytecode versions if the native-code versions are available, except in unusual circumstances. Instead, install the native-code versions without the `.opt` suffix. They are still installed with the `.opt` suffix for backwards compatibility. Finally, install the bytecode versions with the `.byte` suffix, and build native-code versions of tools that are not currently built in native code. Also, remove some duplication in tools/Makefile.shared. Supersedes GPR ocaml#512.
DemiMarie
force-pushed
the
native-by-default2
branch
from
fad2625 to
d89af40
Compare
Contributor
Author
|
Squashed. |
camlspotter
pushed a commit
to camlspotter/ocaml
that referenced
this pull request
Oct 17, 2017
Install native versions of tools by default.
Merged
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
May 24, 2022
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
Pages accessible using different URLs shall include a canonical link, indicating which URL is the best (search Google for “consolidate duplicates URLs”). This is useful for web crawlers. Ahrefs reports “Duplicate pages without canonical” as an issue. This patch adds canonical links to several pages. Main tag generation takes place in layout.eml. Often, it is sufficient to pass the right URL to `Layout.render`. This is the case for: * about.eml * academic_users.eml * best_pratices.eml * blog.eml * books.eml * community.eml * industrial_users.eml * jobs.eml * learn.eml * news.eml * packages.eml * papers.eml * platform.eml * problems.eml * releases.eml * tutorial.eml A few others are almost the same, except some obvious path part needs to be appended. This is the case for: * news_post.eml * release.eml * success_story.eml * workshop.eml Other changes include parameter forwarding: * learn_layout.eml * ocamlorg_frontend.ml * page.eml * tutorial.eml In home.eml, the empty string is used to have "https://ocaml.org" be the best URL (without trailing slash) In handler.ml a combination of parameter forwarding and canonical URL setting takes place. In playground.eml, the string "https://ocaml.org" is hardwired a second time because it uses an ad-hoc layout. No canonical link is generated in not_found.eml, on purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
ocamlc,ocamlopt,ocamllex, andocamldepdefaultedto the bytecode versions of the tools. However, there is normally no
advantage to the bytecode versions if the native-code versions are
available, except in unusual circumstances. Instead, install the
native-code versions without the
.optsuffix. They are stillinstalled with the
.optsuffix for backwards compatibility. Finally,install the bytecode versions with the
.bytesuffix, and buildnative-code versions of tools that are not currently built in native
code.
Also, remove some duplication in tools/Makefile.shared.
Supersedes GPR #512.