Skip to content

PR#7239: clarify Warning 42 (Disambiguated constructor or label name)#561

Merged
gasche merged 1 commit intoocaml:trunkfrom
gasche:clarify-warning-42
Apr 26, 2016
Merged

PR#7239: clarify Warning 42 (Disambiguated constructor or label name)#561
gasche merged 1 commit intoocaml:trunkfrom
gasche:clarify-warning-42

Conversation

@gasche
Copy link
Member

@gasche gasche commented Apr 25, 2016

PR#7239 is a report by Jun Furuse that shows that the wording for warning 42 (the compatibility warning that warns about essential uses of type-directed disambiguation) is confusing. This PR updates the wording from

Warning 42: this use of C required disambiguation.

to

Warning 42: this use of C relies on type-directed disambiguation,
it will not compile with OCaml 4.00 or earlier.

@gasche gasche added this to the 4.04 milestone Apr 25, 2016
@gasche gasche force-pushed the clarify-warning-42 branch from aaf19da to 3c21268 Compare April 25, 2016 22:35
@garrigue
Copy link
Contributor

It looks fine to me.

@gasche gasche merged commit f3fbf1f into ocaml:trunk Apr 26, 2016
mshinwell added a commit to mshinwell/ocaml that referenced this pull request Jul 16, 2021
EduardoRFS pushed a commit to esy-ocaml/ocaml that referenced this pull request Jul 23, 2021
stedolan pushed a commit to stedolan/ocaml that referenced this pull request May 24, 2022
The frame table uses 16-bit unsigned integers to store the size of a
stack frame as well as the number and offsets of roots.

This commit adds a compile-time error if these 16-bit fields overflow.

Closes: ocaml#10072

Co-authored-by: Xavier Leroy <[email protected]>
stedolan pushed a commit to stedolan/ocaml that referenced this pull request May 24, 2022
fe8a98b flambda-backend: Save Mach as Cfg after Selection (ocaml#624)
2b205d8 flambda-backend: Clean up algorithms (ocaml#611)
524f0b4 flambda-backend: Initial refactoring of To_cmm (ocaml#619)
0bf75de flambda-backend: Refactor and correct the "is pure" and "can raise" (port upstream PR#10354 and PR#10387) (ocaml#555)
d234bfd flambda-backend: Cpp mangling is now a configuration option (ocaml#614)
20fc614 flambda-backend: Check that stack frames are not too large (ocaml#10085) (ocaml#561)
5fc2e95 flambda-backend: Allow CSE of immutable loads across stores (port upstream PR#9562) (ocaml#562)
2a650de flambda-backend: Backport commit fc95347 from trunk (ocaml#584)
31651b8 flambda-backend: Improved ARM64 code generation (port upstream PR#9937) (ocaml#556)
f0b6d68 flambda-backend: Simplify processing and remove dead code (error paths) in asmlink (port upstream PR#9943) (ocaml#557)
90c6746 flambda-backend: Improve code-generation for inlined comparisons (port upstream PR#10228) (ocaml#563)

git-subtree-dir: ocaml
git-subtree-split: fe8a98b
lpw25 pushed a commit to lpw25/ocaml that referenced this pull request Jun 21, 2022
…) (ocaml#561)

The frame table uses 16-bit unsigned integers to store the size of a
stack frame as well as the number and offsets of roots.

This commit adds a compile-time error if these 16-bit fields overflow.

Closes: ocaml#10072

Co-authored-by: Xavier Leroy <[email protected]>
EmileTrotignon pushed a commit to EmileTrotignon/ocaml that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants