Conversation
stdlib/set.mli
Outdated
| with respect to the ordering over the type of the elements. *) | ||
|
|
||
| val map: (elt -> elt) -> t -> t | ||
| (** [map f s] creates a new set with elements [f a0], |
There was a problem hiding this comment.
I would replace "creates a new set with elements" by "is a set with elements" (describe the value denoted by the expression).
stdlib/set.mli
Outdated
|
|
||
| val map: (elt -> elt) -> t -> t | ||
| (** If the elements of [s] are [a0],[a1],..[aN], then the elements | ||
| of [map f s] are [f a0],[f a1]... [f aN]. |
There was a problem hiding this comment.
I personally prefer the documentation pattern "[map f s] is ..." it directly tells you how to read the occurence of such an expression in a program.
gasche
force-pushed
the
set-map
branch
2 times, most recently
from
4c9b7b7 to
21006fb
Compare
stdlib/moreLabels.mli
Outdated
| val equal : t -> t -> bool | ||
| val subset : t -> t -> bool | ||
| val iter : f:(elt -> unit) -> t -> unit | ||
| val map : (elt -> elt) -> t -> t |
There was a problem hiding this comment.
Shouldn't this be labeled ?
|
|
Using |
|
I updated the branch. |
|
If we're going to add |
|
I think I'm not going to work on |
…view (ocaml#578) Co-authored-by: Sabine Schmaltz <[email protected]> Co-authored-by: Christine Rose <[email protected]>
Clarifications/rewrites on the "First Hour With OCaml" tutorial. * add a section about using the OCaml Playground * mention what # means in the code examples * spell out what's happening more clearly for beginners --------- Signed-off-by: Christine Rose <[email protected]> Co-authored-by: Christine Rose <[email protected]>
6 participants
PR#6279