Skip to content

Add Travis Continuous Integration files, currently i386 only#47

Closed
avsm wants to merge 1 commit intoocaml:trunkfrom
avsm:upstream-travis
Closed

Add Travis Continuous Integration files, currently i386 only#47
avsm wants to merge 1 commit intoocaml:trunkfrom
avsm:upstream-travis

Conversation

@avsm
Copy link
Member

@avsm avsm commented Apr 29, 2014

Discussed with @planar previously

@gasche
Copy link
Member

gasche commented May 1, 2014

There are a couple things that worry me about using Travis CI.

Subjective worries:

  • this is one more proprietary service to rely on
  • it pains me a bit to think that around twenty minutes of CPU time are spent compiling OCaml again each time a commit is pushed or a pull request is sent. I know that the OCaml community does not pay for this waste energy, but I still find it a bit problematic. On the other hand, compiling OCaml from scratch is a reasonably sensible use of CPU time (other travis setups that first install opam and a load of dependencies that should obviously be cached in a better-designed CI setup pains me more in this regard).

These two objections should be understood in the following context (which is clear to Anil but maybe not to everyone else): there already is a CI service running on the OCaml SVN repository. It is kindly administered by INRIA, is a bit more painful to get information from (you have to explicitly subscribe; this is open to everyone but there is an entrance fee in terms of effort), relies on Jenkins, runs only on trunk, but thanks to heroic work by Damien has both Win and OSX slaves that are very useful (they catch most of the minor troubles, and in the case of OSX some important stack-alignment one).

Objective worries:

  • for now the Travis build does stricly less than the INRIA CI, so it's utility is not obvious. I understand that the long-term goal is to make it cover more areas (and maybe rely entirely on it, to lift a burden off Damien's shoulders), but so far the returns of one more CI should be about nil, with one exception: it would run the testsuite on pull requests.
  • the actual configuration does not only build the ocaml repository, but also Camlp4, Opam and Utop. This is both a good and a bad thing: Camlp4 is excellent at catching bugs/breakage in the compiler and I lament its loss (from the core distribution) in term of compiler code coverage. However, as of last it has been consistently broken for trunk, and my understanding of its development model is that it will try to get up-to-date relatively shortly before the release. What will the value of CI be if it is always red during 70% of a version's timeframe?

@avsm
Copy link
Member Author

avsm commented May 1, 2014

I think you're overthinking a relatively minor addition to the repository (worrying about spending CPU time building every changeset? seriously?). To address some specific concerns:

  • The Travis files also work in forks, which the INRIA CI doesn't.
  • The CI results here are triageable by anyone as part of the GH workflow, whereas the INRIA one is harder to get to. More tests are always better, but more triage is even better.
  • As we're entering a release cycle, the goal is to keep all the moving parts green, not red. The whole point of the CI is to find and fix camlp4 mismatches quickly!
  • It's easier to hook Travis results into OPAM (e.g. to have a known-good compiler switch for trunk and camlp4).

-anil

On 1 May 2014, at 10:51, gasche [email protected] wrote:

There are a couple things that worry me about using Travis CI.

Subjective worries:

this is one more proprietary service to rely on
it pains me a bit to think that around twenty minutes of CPU time are spent compiling OCaml again each time a commit is pushed or a pull request is sent. I know that the OCaml community does not pay for this waste energy, but I still find it a bit problematic. On the other hand, compiling OCaml from scratch is a reasonably sensible use of CPU time (other travis setups that first install opam and a load of dependencies that should obviously be cached in a better-designed CI setup pains me more in this regard).
These two objections should be understood in the following context (which is clear to Anil but maybe not to everyone else): there already is a CI service running on the OCaml SVN repository. It is kindly administered by INRIA, is a bit more painful to get information from (you have to explicitly subscribe; this is open to everyone but there is an entrance fee in terms of effort), relies on Jenkins, runs only on trunk, but thanks to heroic work by Damien has both Win and OSX slaves that are very useful (they catch most of the minor troubles, and in the case of OSX some important stack-alignment one).

Objective worries:

for now the Travis build does stricly less than the INRIA CI, so it's utility is not obvious. I understand that the long-term goal is to make it cover more areas (and maybe rely entirely on it, to lift a burden off Damien's shoulders), but so far the returns of one more CI should be about nil, with one exception: it would run the testsuite on pull requests.
the actual configuration does not only build the ocaml repository, but also Camlp4, Opam and Utop. This is both a good and a bad thing: Camlp4 is excellent at catching bugs/breakage in the compiler and I lament its loss (from the core distribution) in term of compiler code coverage. However, as of last it has been consistently broken for trunk, and my understanding of its development model is that it will try to get up-to-date relatively shortly before the release. What will the value of CI be if it is always red during 70% of a version's timeframe?

Reply to this email directly or view it on GitHub.

@samoht
Copy link
Member

samoht commented May 1, 2014

The goal of Travis CI is primarly to get a quick and easy feedback (portability information and a vague idea of the possible breakage cone) to the one who created the patch.

Having an internal infrastructure to test trunk only is good for other purposes but does not help at all here.

@xavierleroy
Copy link
Contributor

More testing is always good. I expect that at some future time the CI done
at OCaml Labs will subsume the CI done at Inria, at which time the latter
can be retired. For the time being the two CI's are well worth having.

2014-05-01 12:04 GMT+02:00 Thomas Gazagnaire [email protected]:

The goal of Travis CI is primarly to get a quick and easy feedback
(portability information and a vague idea of the possible breakage cone) to
the one who created the patch.

Having an internal infrastructure to test trunk only is good for
other purposes but does not help at all here.


Reply to this email directly or view it on GitHubhttps://github.com//pull/47#issuecomment-41896919
.

@mshinwell
Copy link
Contributor

Magister dixit. I have committed them.
Anil, please close this.

@avsm avsm closed this May 1, 2014
@avsm avsm deleted the upstream-travis branch May 1, 2014 10:36
@avsm
Copy link
Member Author

avsm commented May 1, 2014

This will require some minor tweaks for the latest bits to pass, mainly due to OPAM 1.1 not building against 4.02.0dev. I'll make another pull request as soon as ocaml/opam#1367 (turn off warn-error) is applied.

lpw25 pushed a commit to lpw25/ocaml that referenced this pull request Jun 12, 2016
Native code backend for multicore
anmolsahoo25 pushed a commit to anmolsahoo25/ocaml that referenced this pull request Aug 25, 2020
put the phase change event in the actual phase change code
poechsel pushed a commit to poechsel/ocaml that referenced this pull request Jul 2, 2021
lpw25 pushed a commit to lpw25/ocaml that referenced this pull request Nov 16, 2021
stedolan added a commit to stedolan/ocaml that referenced this pull request May 24, 2022
173842c Merge flambda-backend changes
ed7eba2 Remove leading space from LINE. (oxcaml/oxcaml#484)
bd61170 Bump magic numbers (ocaml#5)
c50c47d Add CI builds with local allocations enabled
1412792 Move local allocations support behind '-extension local'
6d8e42a Better tail call behaviour in caml_applyN
c7dac3d Typemod: toplevel bindings escape even if no variables are bound
82d6c3e Several fixes for partial application and currying
d05c70c Pprintast support for new local syntax
e0e62fc Typecheck x |> f y as (f y x), not ((f y) x)
d7e34ce Remove autogeneration of @ocaml.curry
b9a0593 Port oxcaml/oxcaml#493
0a872d9 Code review fixes from oxcaml/oxcaml#491
6c168bb Remove local allocation counting
3c6e7f0 Code review fixes from oxcaml/oxcaml#478
bb97207 Rename Lambda.apply_position
a7cb650 Quieten Makefile when runtime dep files are not present
c656dc9 Merge flambda-backend changes
11b5424 Avoid printing double spaces in function argument lists
7751faa Restore locations to Typedtree.{pat,let}_bound_idents_full
e450b6c add build_ocaml_compiler.sexp
0403bb3 Revert PR 9895 to continue installing VERSION
b3447db Ensure new local attributes are namespaced properly
7f213fc Allow empty functions again
8f22ad8 Bugfix: ensure local domain state is initialised
80f54dd Bugfix for Selectgen with regions
e8133a1 Fix external-external signature inclusion
9840051 Bootstrap
d879f23 Merge remote-tracking branch 'jane/local-reviewed' into local-merge
94454f5 Use Local_store for the local allocations ref
54a164c Create fewer regions, according to typechecking (ocaml#59)
1c2479b Merge flambda-backend changes
ce34678 Fix printing of modes in return types
91f2281 Hook mode variable solving into Btype.snapshot/backtrack
54e4b09 Move Alloc_mode and Value_mode to Btype
ff4611e Merge flambda-backend changes
ce62e45 Ensure allocations are initialised, even dead ones
6b6ec5a Fix the alloc.ml test on 32-bit builds
81e9879 Merge flambda-backend changes
40a7f89 Update repo URL for ocaml-jst, and rename script.
0454ee7 Add some new locally-allocating primitives (ocaml#57)
8acdda1 Reset the local stack pointer in exception handlers (ocaml#56)
8dafa98 Improve typing for (||) and (&&) (ocaml#55)
8c64754 Fix make_check_all_arches (ocaml#54)
b50cd45 Allow arguments to primitives to be local even in tail position (ocaml#53)
cad125d Fix modes from or-patterns (ocaml#50)
4efdb72 Fix tailcalls tests with inlining (ocaml#52)
4a795cb Flambda support (ocaml#49)
74722cb Add [@ocaml.principal] and [@ocaml.noprincipal] attributes, and use in oo.mli
6d7d3b8 Ensure that functions are evaluated after their arguments (flambda-backend ocaml#353)
89bda6b Keep Sys.opaque_identity in Cmm and Mach (port upstream PR 9412)
a39126a Fix tailcalls within regions (ocaml#48)
4ac4cfd Fix stdlib manpages build
3a95f5e Merge flambda-backend changes
efe80c9 Add jane/pull-flambda-patches script
fca94c4 Register allocations for Omitted parameter closures (ocaml#47)
103b139 Remove various FIXMEs (ocaml#46)
62ba2c1 Bootstrap
a0062ad Allow local allocations for various primitives (ocaml#43)
7a2165e Allow primitives to be poly-moded (ocaml#43)
2af3f55 Fix a flaky test by refactoring TypePairs (ocaml#10638)
58dd807 Bootstrap
ee3be10 Fix modes in build_apply for partial applications
fe73656 Tweak for evaluation order of labelled partial applications (ocaml#10653)
0527570 Fix caml_modify on local allocations (ocaml#40)
e657e99 Relax modes for `as` patterns (ocaml#42)
f815bf2 Add special mode handling for tuples in matches and let bindings (ocaml#38)
39f1211 Only take the upper bounds of modes associated with allocations (ocaml#37)
aec6fde Interpret arrow types in "local positions" differently
c4f3319 Bootstrap
ff6fdad Add some missing regions
40d586d Bootstrap
66d8110 Switch to a system with 3 modes for values
f2c5a85 Bugfix for Comballoc with local allocations. (ocaml#41)
83bcd09 Fix bug with root scanning during compaction (ocaml#39)
1b5ec83 Track modes in Lambda.lfunction and onwards (ocaml#33)
f1e2e97 Port ocaml#10728
56703cd Port ocaml#10081
eb66785 Support local allocations in i386 and fix amd64 bug (ocaml#31)
c936b19 Disallow local recursive non-functions (ocaml#30)
c7a193a GC support for local allocations (ocaml#29)
8dd7270 Nonlocal fields (ocaml#28)
e19a2f0 Bootstrap
694b9ac Add syntax to the parser for local allocations (ocaml#26)
f183008 Lower initial stack size
918226f Allow local closure allocations (ocaml#27)
2552e7d Introduce mode variables (ocaml#25)
bc41c99 Minor fixes for local allocations (ocaml#24)
a2a4e60 Runtime and compiler support for more local allocations (ocaml#23)
d030554 Typechecking for local allocations (ocaml#21)
9ee2332 Bugfix missing from ocaml#20
02c4cef Retain block-structured local regions until Mach.
86dbe1c amd64: Move stack realloc calls out-of-line
324d218 More typing modes and locking of environments
a4080b8 Initial version of local allocation (unsafe)

git-subtree-dir: ocaml
git-subtree-split: 173842c
stedolan pushed a commit to stedolan/ocaml that referenced this pull request Mar 21, 2023
c703f5f Incorporate upstream comments into type-variable refactor (ocaml#121)
362ba23 Constrain curry modes to increase along applications (ocaml#108)
b1f0cf9 Simplify the extension handling (ocaml#114)
4fd53a1 Remove pat_mode from typedtree (ocaml#105)
cf6fcbc Handle attributes on lambdas with locally abstract types (ocaml#120)
5fa80fe Don't track attributes inside attributes for warning 53 (ocaml#115)
8a69777 Handle unclosed `[: ... :]` patterns (via `Generic_array` machinery) (ocaml#117)
b0737f4 Add promote-one Makefile target (ocaml#118)
c6ad684 Refactoring and fixes around module lookup (ocaml#107)
b0a6495 Add documentation for global constructor arguments (ocaml#69)
dd79aec Print `nlocal` in the `-d(raw)lambda` output (ocaml#112)
8035026 Fix `nlocal` in the generated Lambda for list comprehensions (ocaml#113)
afbcdf0 Immutable arrays (ocaml#47)
bfe1490 fix several issues when removing exp_mode (ocaml#110)
8f46060 Better error message for under-applied functions (ocaml#74)
27331d8 Consistently use Lmutvar or Lvar in comprehensions (ocaml#111)
01e965b Skip failing test for now
0131357 Fix test case to use comprehensions_experimental
22a7368 Temporarily disable list comprehensions tests due to locals bug
e08377d Make `comprehensions` into `comprehensions_experimental` for now (ocaml#109)
947cf89 List and array comprehensions (ocaml#46)
bd9e051 remove exp_mode from typedtree (ocaml#100)
a9268d2 Fix misplaced attribute warning when using external parser (and some cleanup) (ocaml#101)
2b33f24 Refactor toplevel local escape check (ocaml#104)
ed2aec6 Comment functions exported from TyVarEnv.
87838ba Move new variable creation into TyVarEnv.
a3f60ab Encapsulate functions that work with tyvars
43d83a6 Prevent possibility of forgetting to re-widen
2f3dd34 Encapsulate context when narrowing type env't
d78ff6d Make immediate64 things mode cross (ocaml#97)
aa25ab9 Fix version number (ocaml#94)
d01ffa0 Fix .depend file (ocaml#93)
942f2ab Bootstrap (ocaml#92)
05f7e38 Check Menhir version (ocaml#91)
1569b58 Move the CI jobs from 4.12 to 4.14. (ocaml#90)

git-subtree-dir: ocaml
git-subtree-split: c703f5f
EmileTrotignon pushed a commit to EmileTrotignon/ocaml that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants