New primitive: caml_alloc_dummy_function ... by hhugo · Pull Request #37 · ocaml/ocaml

hhugo · 2014-04-14T16:47:58Z

caml_alloc_dummy_function takes the function arity as a second argument.
This new information can be used by js_of_ocaml to perform better optimization.

hhugo · 2014-04-22T09:33:38Z

cc @vouillon

vouillon · 2014-05-07T08:45:59Z

For recursive let expressions involving both values and functions, a dummy block is allocated for each bound variable. The contents of this block is later overwritten with the correct data (primitive caml_update_dummy). This does not make sense for JavaScript closures.

We currently have a hack to deal with that. We put the closure in a property fun of the block. Then, on function invocation, we need to check whether we have a JavaScript closure or a block with this property...

Having a special primitive for allocating dummy closure would make it possible to remove this check. Instead, we would allocate a closure function f(x) {return f.fun(x)}.

hhugo · 2014-05-13T13:30:22Z

any chance to see this into the 4.02 branch ?

gasche · 2014-08-28T18:19:24Z

I'm reviewing the pull requests and realize we forgot to provide much feedback on this one. I think it's a good idea in principle, but it came too late in the 4.02 release cycle for us to do much about it. After the release (this summer!) there'll be more time to discuss this, and I hope we come to a decision.

caml_alloc_dummy_function takes the function arity as a second argument. This new information can be used by js_of_ocaml to perform better optimization.

bobot · 2014-11-11T14:36:28Z

This PR have been discussed during the last developers' meeting, where I had the pleasure to be. To sum-up:

can lead in bytecode to less efficient code but only in function recursive with value, which is quite unusual.
Ok for integration

gasche · 2014-11-17T12:39:24Z

Merged in trunk. (I didn't mention it in the Changes file because I wasn't quite sure how to present the change in an understandable way. Next time, do not hesitate to write a Changes line yourself ^^)

Some more parsing stuff and some tests for flambda-to-cmm

More safepoints

…l#37)

173842c Merge flambda-backend changes ed7eba2 Remove leading space from LINE. (oxcaml/oxcaml#484) bd61170 Bump magic numbers (ocaml#5) c50c47d Add CI builds with local allocations enabled 1412792 Move local allocations support behind '-extension local' 6d8e42a Better tail call behaviour in caml_applyN c7dac3d Typemod: toplevel bindings escape even if no variables are bound 82d6c3e Several fixes for partial application and currying d05c70c Pprintast support for new local syntax e0e62fc Typecheck x |> f y as (f y x), not ((f y) x) d7e34ce Remove autogeneration of @ocaml.curry b9a0593 Port oxcaml/oxcaml#493 0a872d9 Code review fixes from oxcaml/oxcaml#491 6c168bb Remove local allocation counting 3c6e7f0 Code review fixes from oxcaml/oxcaml#478 bb97207 Rename Lambda.apply_position a7cb650 Quieten Makefile when runtime dep files are not present c656dc9 Merge flambda-backend changes 11b5424 Avoid printing double spaces in function argument lists 7751faa Restore locations to Typedtree.{pat,let}_bound_idents_full e450b6c add build_ocaml_compiler.sexp 0403bb3 Revert PR 9895 to continue installing VERSION b3447db Ensure new local attributes are namespaced properly 7f213fc Allow empty functions again 8f22ad8 Bugfix: ensure local domain state is initialised 80f54dd Bugfix for Selectgen with regions e8133a1 Fix external-external signature inclusion 9840051 Bootstrap d879f23 Merge remote-tracking branch 'jane/local-reviewed' into local-merge 94454f5 Use Local_store for the local allocations ref 54a164c Create fewer regions, according to typechecking (ocaml#59) 1c2479b Merge flambda-backend changes ce34678 Fix printing of modes in return types 91f2281 Hook mode variable solving into Btype.snapshot/backtrack 54e4b09 Move Alloc_mode and Value_mode to Btype ff4611e Merge flambda-backend changes ce62e45 Ensure allocations are initialised, even dead ones 6b6ec5a Fix the alloc.ml test on 32-bit builds 81e9879 Merge flambda-backend changes 40a7f89 Update repo URL for ocaml-jst, and rename script. 0454ee7 Add some new locally-allocating primitives (ocaml#57) 8acdda1 Reset the local stack pointer in exception handlers (ocaml#56) 8dafa98 Improve typing for (||) and (&&) (ocaml#55) 8c64754 Fix make_check_all_arches (ocaml#54) b50cd45 Allow arguments to primitives to be local even in tail position (ocaml#53) cad125d Fix modes from or-patterns (ocaml#50) 4efdb72 Fix tailcalls tests with inlining (ocaml#52) 4a795cb Flambda support (ocaml#49) 74722cb Add [@ocaml.principal] and [@ocaml.noprincipal] attributes, and use in oo.mli 6d7d3b8 Ensure that functions are evaluated after their arguments (flambda-backend ocaml#353) 89bda6b Keep Sys.opaque_identity in Cmm and Mach (port upstream PR 9412) a39126a Fix tailcalls within regions (ocaml#48) 4ac4cfd Fix stdlib manpages build 3a95f5e Merge flambda-backend changes efe80c9 Add jane/pull-flambda-patches script fca94c4 Register allocations for Omitted parameter closures (ocaml#47) 103b139 Remove various FIXMEs (ocaml#46) 62ba2c1 Bootstrap a0062ad Allow local allocations for various primitives (ocaml#43) 7a2165e Allow primitives to be poly-moded (ocaml#43) 2af3f55 Fix a flaky test by refactoring TypePairs (ocaml#10638) 58dd807 Bootstrap ee3be10 Fix modes in build_apply for partial applications fe73656 Tweak for evaluation order of labelled partial applications (ocaml#10653) 0527570 Fix caml_modify on local allocations (ocaml#40) e657e99 Relax modes for `as` patterns (ocaml#42) f815bf2 Add special mode handling for tuples in matches and let bindings (ocaml#38) 39f1211 Only take the upper bounds of modes associated with allocations (ocaml#37) aec6fde Interpret arrow types in "local positions" differently c4f3319 Bootstrap ff6fdad Add some missing regions 40d586d Bootstrap 66d8110 Switch to a system with 3 modes for values f2c5a85 Bugfix for Comballoc with local allocations. (ocaml#41) 83bcd09 Fix bug with root scanning during compaction (ocaml#39) 1b5ec83 Track modes in Lambda.lfunction and onwards (ocaml#33) f1e2e97 Port ocaml#10728 56703cd Port ocaml#10081 eb66785 Support local allocations in i386 and fix amd64 bug (ocaml#31) c936b19 Disallow local recursive non-functions (ocaml#30) c7a193a GC support for local allocations (ocaml#29) 8dd7270 Nonlocal fields (ocaml#28) e19a2f0 Bootstrap 694b9ac Add syntax to the parser for local allocations (ocaml#26) f183008 Lower initial stack size 918226f Allow local closure allocations (ocaml#27) 2552e7d Introduce mode variables (ocaml#25) bc41c99 Minor fixes for local allocations (ocaml#24) a2a4e60 Runtime and compiler support for more local allocations (ocaml#23) d030554 Typechecking for local allocations (ocaml#21) 9ee2332 Bugfix missing from ocaml#20 02c4cef Retain block-structured local regions until Mach. 86dbe1c amd64: Move stack realloc calls out-of-line 324d218 More typing modes and locking of environments a4080b8 Initial version of local allocation (unsafe) git-subtree-dir: ocaml git-subtree-split: 173842c

* implement a sticky footer

* import academic data * Revert "import academic data" This reverts commit edb8ba44267ffb4a518637f769d0f45d69fd4c9a. * import academic data

hhugo mentioned this pull request Apr 15, 2014

Making the OCaml compiler more friendly to Js_of_ocaml ocsigen/js_of_ocaml#117

Open

7 tasks

New primitive: caml_alloc_dummy_function ...

74bf4a2

caml_alloc_dummy_function takes the function arity as a second argument. This new information can be used by js_of_ocaml to perform better optimization.

hhugo force-pushed the caml_alloc_dummy_function branch from 77352c1 to 74bf4a2 Compare September 22, 2014 11:06

gasche closed this Nov 17, 2014

hhugo deleted the caml_alloc_dummy_function branch December 22, 2015 10:15

Gbury pushed a commit to Gbury/ocaml that referenced this pull request Oct 18, 2019

Merge pull request ocaml#37 from chambart/flambda2.0-stable-parse

c6e74b4

Some more parsing stuff and some tests for flambda-to-cmm

anmolsahoo25 pushed a commit to anmolsahoo25/ocaml that referenced this pull request Aug 25, 2020

Merge pull request ocaml#37 from stedolan/more-safepoints

de53ffc

More safepoints

poechsel pushed a commit to poechsel/ocaml that referenced this pull request Jul 2, 2021

Fix typo in Cpopcnt constructor in Proc.operation_supported (ocaml#37)

558f4e8

stedolan pushed a commit to lpw25/ocaml that referenced this pull request Nov 10, 2021

Only take the upper bounds of modes associated with allocations (ocam…

c451087

…l#37)

lpw25 added a commit to lpw25/ocaml that referenced this pull request Nov 12, 2021

Only take the upper bounds of modes associated with allocations (ocam…

39f1211

…l#37)

hhugo mentioned this pull request Jan 23, 2023

Fix compilation of some mutually recursive functions ocsigen/js_of_ocaml#1393

Merged

EmileTrotignon pushed a commit to EmileTrotignon/ocaml that referenced this pull request Jan 12, 2024

Implement rough footer (ocaml#37)

23ea84d

* implement a sticky footer

EmileTrotignon pushed a commit to EmileTrotignon/ocaml that referenced this pull request Jan 12, 2024

import academic data (ocaml#37)

7aeabca

* import academic data * Revert "import academic data" This reverts commit edb8ba44267ffb4a518637f769d0f45d69fd4c9a. * import academic data

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New primitive: caml_alloc_dummy_function ...#37

New primitive: caml_alloc_dummy_function ...#37
hhugo wants to merge 1 commit intoocaml:trunkfrom
hhugo:caml_alloc_dummy_function

hhugo commented Apr 14, 2014

Uh oh!

hhugo commented Apr 22, 2014

Uh oh!

vouillon commented May 7, 2014

Uh oh!

hhugo commented May 13, 2014

Uh oh!

gasche commented Aug 28, 2014

Uh oh!

bobot commented Nov 11, 2014

Uh oh!

gasche commented Nov 17, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hhugo commented Apr 14, 2014

Uh oh!

hhugo commented Apr 22, 2014

Uh oh!

vouillon commented May 7, 2014

Uh oh!

hhugo commented May 13, 2014

Uh oh!

gasche commented Aug 28, 2014

Uh oh!

bobot commented Nov 11, 2014

Uh oh!

gasche commented Nov 17, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants