Various test-suite fixes for Windows#366
Conversation
|
There is one issue which I don't know the implications of: As far as I can tell, you cannot alter the stack size in Cygwin (at least not with ulimit). Does that have implications for this test? If not, shall I put a test using uname for Cygwin to short-circuit the command just to remove the erroneous looking output? |
|
The commits seem fine so far -- I would have merged them without your warning. The |
|
Hmm - Cygwin certainly has a default limit, but I don't know how it's arrived at. For example, the machine I'm on (fairly old Cygwin) has |
|
On Linux, you can set |
|
75a000d added to eliminate the ulimit call on Cygwin. Also a minor bit of tidying in make -f Makefile.nt [dist]clean |
607c9ce to
6108518
Compare
Stray `\r` characters included in the attribute when parsed on Windows. Fixed by specifying that deprecated_module.mli must be checked out with LF endings.
6108518 to
9cf9c88
Compare
|
Right - this is all ready-to-go as far as I'm concerned. The |
|
The commits look reasonably atomic. I'll wait for #370 to be merged (it's still waiting on some further changes if I understand correctly) and merge this one then. |
cec3811 to
1d60930
Compare
da08390 to
2e32cca
Compare
|
Rebased in order to include a small fix for #319 |
2e32cca to
e243bf8
Compare
5a3c2af to
34726d4
Compare
|
OK - hopefully that really is the last change appropriate to this PR! A small revision to the third commit (1cc554f) to include .runner scripts. The last commit re-enables a disabled test (lib-threads/sockets.ml) and adds support for a lib-threads/signal.ml - Windows may not have signals, but it does have a reliable way to send CTRL+C to a console program. |
|
About copyright headers: we recently decided that they are not needed in |
|
Could you pull all the |
|
OK for merge after the |
XML sample document behaves differently when checked out on Windows where the source line endings in the test document become `\r\n`. Alternative would have been to specify that t01.ml needs LF endings in .gitattributes, but explicitly including the \n and \t in the OCaml string seems less brittle.
Testing the parsetree fails on Windows because the .ml files have `\r\n` endings. For these tests, simplest simply to ensure that they are checked out using LF endings, even on Windows.
.precheck, .runner and .checker files are part of scripts and need to have LF line-endings.
Cygwin doesn't allow the stack limit (uname -s) to be changed, though it can be queried. Alter the test so that the stack limit is only changed if it is either unlimited or very large (and skip the tests if ulimit returns an error)
Warnings tests didn't check `$(BYTECODE_ONLY)`
Various testsuite Makefiles displaying commands, which fog up the log files.
The `CANKILL` testsuite variable is eliminated in favour of testing for `TOOLCHAIN`. tests/lib-threads/signal.ml can be executed under native Windows by means of a wrapper program to send CTRL+C. tests/lib-threads/signal2.ml is not possible under native Windows because Thread.sigmask is not implemented, so the precheck is updated to reflect this, rather than the lack of kill -INT. tests/lib-threads/sockets.ml is re-enabled, since the two MPRs affecting it have been fixed.
34726d4 to
b505fc6
Compare
|
|
GPR#366: Various test-suite fixes for Windows
Add event to record idle domains
These commits deal with various issues introduced in d8b7a4f causing the line endings of some files in the test suite to be altered.
These patches restore full operation to the test suite tested, so far, using Visual Studio 2005 Professional SP1 x86 & x64.