Skip to content

fix pr7103#365

Merged
garrigue merged 1 commit intoocaml:trunkfrom
hhugo:constraint
Dec 22, 2015
Merged

fix pr7103#365
garrigue merged 1 commit intoocaml:trunkfrom
hhugo:constraint

Conversation

@hhugo
Copy link
Contributor

@hhugo hhugo commented Dec 21, 2015

Prevent printing just a type variable on one side of the clash

This is an attempt to resolve http://caml.inria.fr/mantis/view.php?id=7103
I have little confidence in this been the right change.

the following type error

Type a is not compatible with type 'a

should contain the constraint on 'a.

Type a is not compatible with type < .. > as 'a
Type a is not compatible with type [>``b] as 'a

@garrigue
Copy link
Contributor

I see. The change is actually pretty simple.
I what you want is to prevent printing just a type variable on one side of the clash, then this seems to be the right approach. I cannot guarantee that the result will always be optimal, but this seems to make sense.

@gasche
Copy link
Member

gasche commented Dec 21, 2015

@garrigue , feel free to merge the patch (by cliking the green 'Merge pull request' button) if you think it can go in trunk.

@hhugo is not having a Changes entry intentional?

@hhugo
Copy link
Contributor Author

hhugo commented Dec 21, 2015

I was waiting for some feedback. I'll add an entry now

the following type error

"Type a is not compatible with type 'a"

should contain the constraint on 'a.

"Type a is not compatible with type 'a = < .. >"
"Type a is not compatible with type 'a = [> `b]"
garrigue added a commit that referenced this pull request Dec 22, 2015
Prevent printing just a type variable on one side of the clash (pr#7103)
@garrigue garrigue merged commit 83e3d1b into ocaml:trunk Dec 22, 2015
@hhugo hhugo deleted the constraint branch December 22, 2015 08:50
poechsel added a commit to poechsel/ocaml that referenced this pull request Mar 29, 2021
stedolan pushed a commit to stedolan/ocaml that referenced this pull request Mar 22, 2022
…ing reports (ocaml#365)

* Implemented inlining history

* Add links between apply node and there respective function declaration

* Fix formatting for inlining arguments

* Inlining reports are now showing all decisions taken for any paths, making them work both with simplify and closure conversion
stedolan pushed a commit to stedolan/ocaml that referenced this pull request May 24, 2022
…l#365)

* Implemented inlining history

* Add links between apply node and there respective function declaration

* Fix formatting for inlining arguments

* Inlining reports are now showing all decisions taken for any paths, making them work both with simplify and closure conversion
stedolan added a commit to stedolan/ocaml that referenced this pull request May 24, 2022
64235a3 flambda-backend: Change Float.nan from sNaN to qNaN (ocaml#466)
14a8e27 flambda-backend: Track GC work for all managed bigarray allocations (upstream 11022) (ocaml#569)
c3cda96 flambda-backend: Add two new methods to targetint for dwarf (ocaml#560)
e6f1fed flambda-backend: Handle arithmetic overflow in select_addr (ocaml#570)
dab7209 flambda-backend: Add Target_system to ocaml/utils (ocaml#542)
82d5044 flambda-backend: Enhance numbers.ml with more primitive types (ocaml#544)
216be99 flambda-backend: Fix flambda_o3 and flambda_oclassic attributes (ocaml#536)
4b56e07 flambda-backend: Test naked pointer root handling (ocaml#550)
40d69ce flambda-backend: Stop local function optimisation from moving code into function bodies; opaque_identity fixes for class compilation (ocaml#537)
f08ae58 flambda-backend: Implemented inlining history and use it inside inlining reports (ocaml#365)
ac496bf flambda-backend: Disable the local keyword in typing (ocaml#540)
7d46712 flambda-backend: Bugfix for Typedtree generation of arrow types (ocaml#539)
61a7b47 flambda-backend: Insert missing page table check in roots_nat.c (ocaml#541)
323bd36 flambda-backend: Compiler error when -disable-all-extensions and -extension are used (ocaml#534)
d8956b0 flambda-backend: Persistent environment and reproducibility (ocaml#533)
4a0c89f flambda-backend: Revert "Revert bswap PRs (480 and 482)" (ocaml#506)
7803705 flambda-backend: Cause a C warning when CAMLreturn is missing in C stubs. (ocaml#376)
6199db5 flambda-backend: Improve unboxing during cmm for Flambda (ocaml#295)
96b9e1b flambda-backend: Print diagnostics at runtime for Invalid (ocaml#530)
42ab88e flambda-backend: Disable bytecode compilers in ocamltest (ocaml#504)
58c72d5 flambda-backend: Backport ocaml#10595 from upstream/trunk (ocaml#471)
1010539 flambda-backend: Use C++ name mangling convention (ocaml#483)
81881bb flambda-backend: Local allocation test no longer relies on lifting (ocaml#525)
f5c4719 flambda-backend: Fix an assertion in Closure that breaks probes (ocaml#505)
c2cf2b2 flambda-backend: Add some missing command line arguments to ocamlnat (ocaml#499)

git-subtree-dir: ocaml
git-subtree-split: 64235a3
EmileTrotignon pushed a commit to EmileTrotignon/ocaml that referenced this pull request Jan 12, 2024
Bumps [ood](https://github.com/ocaml/ood) from `738e61a` to `b37db9c`.
- [Release notes](https://github.com/ocaml/ood/releases)
- [Commits](ocaml/ood@738e61a...b37db9c)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
EmileTrotignon pushed a commit to EmileTrotignon/ocaml that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants