Threads/Pervasives: define [min_int] and [max_int] without assuming that integers are either 31 or 63 bits#35
Closed
hhugo wants to merge 1 commit intoocaml:trunkfrom
Closed
Threads/Pervasives: define [min_int] and [max_int] without assuming that integers are either 31 or 63 bits#35hhugo wants to merge 1 commit intoocaml:trunkfrom
hhugo wants to merge 1 commit intoocaml:trunkfrom
Conversation
|
The commit log could use some love. Rule of thumb: the commit log should explain what changed and why in enough detail that you don't need to look at the actual commit to figure it out. |
Contributor
Author
|
True. love is in the log.. |
Member
|
Of course, I should have thought of this when modifying Will fix. |
Member
|
Fixed in trunk. |
stedolan
added a commit
to stedolan/ocaml
that referenced
this pull request
Nov 28, 2016
Move based promotion
This was referenced Mar 14, 2019
anmolsahoo25
pushed a commit
to anmolsahoo25/ocaml
that referenced
this pull request
Aug 25, 2020
Move release barrier to when all domains finish the minor gc
poechsel
pushed a commit
to poechsel/ocaml
that referenced
this pull request
Jul 2, 2021
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Sep 21, 2022
2118848 Ensure that (if c then E) counts E as tail position for typing (ocaml#42) a937de9 Remove mode variables in ocamlc -i (ocaml#41) 865d039 Improve typing of local unboxed values (ocaml#26) 97be59d Backport PR 10090 (ocaml#39) 7613440 Allow use of `local_` to adjust regions for loops. (ocaml#35) git-subtree-dir: ocaml git-subtree-split: 2118848
sadiqj
pushed a commit
to sadiqj/ocaml
that referenced
this pull request
Feb 21, 2023
This patch changes the local stack region behavior for the body of for loops, and the body and condition of while loops. Now, the user may request that no new stack region is created for these positions, and instead local allocations happen in the region containing the loop. This is of limited use in isolation, but is useful with the coming "let mutable" patch, where we want to allow locals in a loop body to "escape" to mutable variables declared in the scope containing the loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow https://github.com/ocaml/ocaml/pull/19/files