Add AppVeyor continuous integration by Chris00 · Pull Request #307 · ocaml/ocaml

Chris00 · 2015-11-23T19:38:59Z

This enables AppVeyor to compile OCaml Win64. So far it chokes on

    sed -e '/\/\*/d' \
        -e '/^#/d' \
        -e 's/enum \(.*\) {/let names_of_\1 = [|/' \
        -e 's/.*};$$/ |]/' \
        -e 's/\([A-Z][A-Z_0-9a-z]*\)/"\1"/g' \
        -e 's/,/;/g' \

in Makefile.shared. Anybody has an idea? (I am a bit surprised as the Win64 compilation has obviously been tested.)

tomjridge · 2015-11-23T22:14:37Z

maybe

-e '/[/][*]/ d'

?

On 23 November 2015 at 19:39, Christophe Troestler <[email protected]

wrote:

This enables AppVeyor to compile OCaml Win64. So far it chokes
https://ci.appveyor.com/project/Chris00/ocaml/build/1.0.43#L743 on
sed -e '/\/\*/d' \
    -e '/^#/d' \        -e 's/enum $.*$ {/let names_of_\1 = [|/' \        -e 's/.*};$$/ |]/' \        -e 's/$[A-Z][A-Z_0-9a-z]*$/"\1"/g' \        -e 's/,/;/g' \
in Makefile.shared. Anybody has an idea? (I am a bit surprised as the

Win64 compilation has obviously been tested.)

You can view, comment on, or merge this pull request online at:

#307
Commit Summary

Add AppVeyor continuous integration

File Changes

A appveyor.yml
https://github.com/ocaml/ocaml/pull/307/files#diff-0 (58)

A appveyor_build.sh
https://github.com/ocaml/ocaml/pull/307/files#diff-1 (34)

Patch Links:

https://github.com/ocaml/ocaml/pull/307.patch

https://github.com/ocaml/ocaml/pull/307.diff

—
Reply to this email directly or view it on GitHub
#307.

Chris00 · 2015-11-23T22:36:15Z

@tomjridge This works, thanks. Still wondering why the previous version fails — it has been in place since the beginning and some people have compiled it on Windows before...

Chris00 · 2015-11-25T14:00:43Z

AppVeyor is green. Is there any interest in this continuous integration possibility (likely tweaking the current script which is minimal). It can also produce artifacts which may possibly be used to automatically generate Windows packages upon successful compilation.

avsm · 2015-11-25T14:02:54Z

We use Appveyor in several other contexts; I am happy to activate it as a paid account on ocaml/ocaml if this is merged.

gasche · 2015-11-29T21:46:30Z

We have some testing running on Windows machine on the INRIA continuous integration platform (ci.inria.fr/ocaml). I would be in favor of integrating the weird quoting stuff (I suppose it is for paths with spaces in them?) and fixing the sed script if it is problematic in some cases, but I'm not personally very excited about burning more CPU somewhere in the world on each pull-request. (No strong opposition either, though.)

Chris00 · 2015-11-30T23:03:38Z

I have started work elsewhere to have an easy way to make Win64 OCaml available for AppVeyor testing. Integrating the quoting stuff (needed indeed for paths with spaces) would be nice as I have to patch the sources ATM.

chambart · 2015-12-01T14:15:22Z

@gasche I think that like travis, this is quite important to make pull request management lighter since almost nobody (except Alain) test his patches on windows before submitting.

alainfrisch · 2015-12-02T09:28:29Z

Yes, and even some core developers don't follow INRIA's CI feedback. I'm fully in favor of these extra tests.

@avsm I thought AppVeyor was free for open source projects.

shayne-fletcher · 2015-12-02T12:05:49Z

I've had problems with this before. The issue turned out to be a MinGW
'sed' executable in the path instead of the Cygwin version.

On Mon, Nov 23, 2015 at 2:39 PM, Christophe Troestler <
[email protected]> wrote:

This enables AppVeyor to compile OCaml Win64. So far it chokes
https://ci.appveyor.com/project/Chris00/ocaml/build/1.0.43#L743 on
sed -e '/\/\*/d' \
    -e '/^#/d' \        -e 's/enum $.*$ {/let names_of_\1 = [|/' \        -e 's/.*};$$/ |]/' \        -e 's/$[A-Z][A-Z_0-9a-z]*$/"\1"/g' \        -e 's/,/;/g' \
in Makefile.shared. Anybody has an idea? (I am a bit surprised as the

Win64 compilation has obviously been tested.)

You can view, comment on, or merge this pull request online at:

#307
Commit Summary

Add AppVeyor continuous integration

File Changes

A appveyor.yml
https://github.com/ocaml/ocaml/pull/307/files#diff-0 (58)

A appveyor_build.sh
https://github.com/ocaml/ocaml/pull/307/files#diff-1 (34)

Patch Links:

https://github.com/ocaml/ocaml/pull/307.patch

https://github.com/ocaml/ocaml/pull/307.diff

—
Reply to this email directly or view it on GitHub
#307.

Shayne Fletcher

Chris00 · 2015-12-03T14:30:42Z

@shayne-fletcher I checked and %CYG_ROOT%/bin/bash -lc "sed --version" reports:

/usr/bin/sed (GNU sed) 4.2.2
Copyright (C) 2012 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Jay Fenlason, Tom Lord, Ken Pizzini,
and Paolo Bonzini.
GNU sed home page: <http://www.gnu.org/software/sed/>.
General help using GNU software: <http://www.gnu.org/gethelp/>.
E-mail bug reports to: <[email protected]>.
Be sure to include the word ``sed'' somewhere in the ``Subject:'' field.

Odd.

bschommer · 2015-12-03T14:47:09Z

A simple way to avoid this problems is to reset the path to only point to cygwin before starting the script.

Chris00 · 2015-12-04T15:35:36Z

I added make tests. They currently fail. Is this the right way of running the tests on Windows?

gasche · 2015-12-17T16:10:24Z

Well if we think the extra testing is useful then we should merge it as soon as possible.

mshinwell · 2016-01-29T14:40:15Z

@Chris00 Please make the fix Damien requested about && in Makefile.nt. Then we can merge this.

mshinwell · 2016-01-29T14:40:29Z

@Chris00 And please resolve the merge conflict(s).

Suggestion of Damien Doligez.

damiendoligez · 2016-02-01T16:44:45Z

About sed versions, see also http://caml.inria.fr/mantis/view.php?id=5991
There is something fishy about some versions of sed 4.2.2, and the FSF web site lists 4.2.1 as the latest version.

damiendoligez · 2016-02-10T13:47:35Z

Merged (commit 37edba7).

damiendoligez · 2016-02-12T14:42:32Z

@Chris00 I just noticed this PR contains enough code to be over the threshold, so could you please sign and return the CLA? Instructions are here: #342 (comment)

Thanks.

This summarizes Xavier's recommendations at ocaml#342 (comment) which were later reused at ocaml#307 (comment) In particular this should create a URL anchor to direct people to:

This summarizes Xavier's recommendations at ocaml#342 (comment) which were later reused at ocaml#307 (comment) In particular this should create a URL anchor to direct people to: https://github.com/ocaml/ocaml/blob/trunk/CONTRIBUTING.md#how-to-sign-the-cla

damiendoligez · 2016-02-24T13:43:56Z

@Chris00 ping?

Chris00 · 2016-02-24T15:15:24Z

I intend to sign it but, as I need my employer permission, I am waiting for his answer (the question already went through 3 administrative services, each one sending it to the next...).

damiendoligez · 2016-02-24T15:17:10Z

So it's in progress. Good!

This summarizes Xavier's recommendations at ocaml#342 (comment) which were later reused at ocaml#307 (comment) In particular this should create a URL anchor to direct people to: https://github.com/ocaml/ocaml/blob/trunk/CONTRIBUTING.md#how-to-sign-the-cla

…eturn-type Introduce Simplify_named_result

Chris00 force-pushed the trunk branch from fdc8e35 to 050cd6c Compare November 23, 2015 22:08

Chris00 force-pushed the trunk branch from 050cd6c to 13f1ddf Compare November 23, 2015 22:17

Chris00 force-pushed the trunk branch 10 times, most recently from 3f5d398 to 4657439 Compare November 25, 2015 07:39

Chris00 force-pushed the trunk branch 2 times, most recently from 7c9316f to 1897b07 Compare November 29, 2015 11:24

Chris00 force-pushed the trunk branch 4 times, most recently from 0dd4ec3 to 01d4883 Compare December 4, 2015 14:06

damiendoligez added the approved label Dec 17, 2015

damiendoligez added this to the 4.03.0 milestone Dec 23, 2015

Chris00 added 4 commits January 29, 2016 17:49

Protect install paths against spaces (on Windows)

7eb2c0a

Add AppVeyor testing

0857e9d

Make AppVeyor run tests

489ed28

Avoid calling make recursively when "testsuite" is not present

088f344

Suggestion of Damien Doligez.

Chris00 force-pushed the trunk branch from 9ae063e to 088f344 Compare January 29, 2016 17:01

ghost mentioned this pull request Jan 29, 2016

ocaml tool to extract opcode information #449

Closed

damiendoligez self-assigned this Feb 10, 2016

damiendoligez closed this Feb 10, 2016

damiendoligez changed the title ~~[WIP] Add AppVeyor continuous integration~~ Add AppVeyor continuous integration Feb 10, 2016

gasche mentioned this pull request Feb 12, 2016

CONTRIBUTING: how to sign the CLA #470

Merged

alainfrisch mentioned this pull request Mar 14, 2016

The Makefile.nt Rampage #507

Closed

gasche mentioned this pull request Dec 9, 2016

ocaml tool to extract opcode information #803

Merged

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Feb 12, 2021

Merge pull request ocaml#307 from mshinwell/flambda2-simplify-named-r…

e5f7b0f

…eturn-type Introduce Simplify_named_result

chambart pushed a commit to chambart/ocaml-1 that referenced this pull request Jan 4, 2022

Fix typos in typing documentation (ocaml#307)

aca3bee

EmileTrotignon pushed a commit to EmileTrotignon/ocaml that referenced this pull request Jan 12, 2024

Update navbar for 99 problems (ocaml#307)

bfe9b24

Conversation

Chris00 commented Nov 23, 2015

Uh oh!

tomjridge commented Nov 23, 2015

Win64 compilation has obviously been tested.)

Uh oh!

Chris00 commented Nov 23, 2015

Uh oh!

Chris00 commented Nov 25, 2015

Uh oh!

avsm commented Nov 25, 2015

Uh oh!

gasche commented Nov 29, 2015

Uh oh!

Chris00 commented Nov 30, 2015

Uh oh!

chambart commented Dec 1, 2015

Uh oh!

alainfrisch commented Dec 2, 2015

Uh oh!

shayne-fletcher commented Dec 2, 2015

Win64 compilation has obviously been tested.)

Uh oh!

Chris00 commented Dec 3, 2015

Uh oh!

bschommer commented Dec 3, 2015

Uh oh!

Chris00 commented Dec 4, 2015

Uh oh!

gasche commented Dec 17, 2015

Uh oh!

mshinwell commented Jan 29, 2016

Uh oh!

mshinwell commented Jan 29, 2016

Uh oh!

damiendoligez commented Feb 1, 2016

Uh oh!

damiendoligez commented Feb 10, 2016

Uh oh!

damiendoligez commented Feb 12, 2016

Uh oh!

damiendoligez commented Feb 24, 2016

Uh oh!

Chris00 commented Feb 24, 2016

Uh oh!

damiendoligez commented Feb 24, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants