The detection of sizes via limits.h is clever and has some chance of being portable, assuming the C standard headers conform to C99 (section 5.2.4.1, "The values given below shall be replaced by constant expressions suitable for use in #if preprocessing directives.")

Endianness detection, on the other hand, is hopelessly not portable; at best, it could be a fallback best effort in the cross-compilation case.

Concerning the test for negative division, it is not needed for C99 indeed, and was removed in the trunk sources.

I take it that for your project you're only interested in the OCaml bytecode compiler and run-time system, not the native-code compiler, right?

2015-10-09 18:46 GMT+02:00 Xavier Leroy [email protected]:

The detection of sizes via limits.h is clever and has some chance of being
portable, assuming the C standard headers conform to C99 (section 5.2.4.1,
"The values given below shall be replaced by constant expressions suitable
for use in #if preprocessing directives.")

Endianness detection, on the other hand, is hopelessly not portable; at
best, it could be a fallback best effort in the cross-compilation case.

I wouldn't say hopeless. I think it's more hopeless to hardcode the
endianess for every possible cross-compilation target in configure script.
Do you have any better idea? I will create a patch which will use the
preprocessor detection only in case of cross-compilation.

Concerning the test for negative division, it is not needed for C99
indeed, and was removed in the trunk sources.

I take it that for your project you're only interested in the OCaml
bytecode compiler and run-time system, not the native-code compiler, right?

I would use the native code compiler, but it's not supported for many
targets, e.g. for mips. So yes, the native compiler has a low priority. I'm
interested in getting OCaml applications as small as possible, as most
openwrt target are space constraint. Openwrt users will probably use 1 or 2
OCaml applications on a target, so I think the best way will be to compile
OCaml applications with -custom.

—
Reply to this email directly or view it on GitHub
#256 (comment).

@the2masters Why do you closed your pull request? Do you know that you can push new commits to your branch in order to update the pull-request?

I know, but I wanted to create a new clean pull request.

2015-10-12 8:10 GMT+02:00 François Bobot [email protected]:

@the2masters https://github.com/the2masters Why do you closed your pull
request? Do you know that you can push new commits to your branch in order
to update the pull-request?

—
Reply to this email directly or view it on GitHub
#256 (comment).

I know, but I wanted to create a new clean pull request.

You can (and should) always force push to make the request clean based on the feedback you get. Opening new requests is annoying as it dilutes the discussions and comments across many PR, making follow up harder than it should be for everybody.