Skip to content

OCamlbuild: Fix the check of ocamlfind#20

Closed
kit-ty-kate wants to merge 2 commits intoocaml:trunkfrom
kit-ty-kate:fix-ocamlfind-check
Closed

OCamlbuild: Fix the check of ocamlfind#20
kit-ty-kate wants to merge 2 commits intoocaml:trunkfrom
kit-ty-kate:fix-ocamlfind-check

Conversation

@kit-ty-kate
Copy link
Member

As noticed in the following issues, ocamlbuild checks if ocamlfind is present too early (as it should be done after the After_options hook).
ocaml/opam-repository#1641
camlp4/camlp4#14

However, it appeared to be a difficult problem because of plugin tags. So a warning still appears if ocamlfind has been disabled in the plugin since ocamlfind is used to build the plugin itself.

I've also added a little patch that fixes a shadowing bug (maybe I should have done another PR for that).

@gasche
Copy link
Member

gasche commented May 3, 2014

I'm a bit reluctant to change this behavior as I have no idea who may depend on the way it's currently done. It makes sense to check for ocamlfind after the options, but it's also reasonable to consider that the after_options hook is a good place to override the ocamlc/ocamlopt/etc. setting if the users decides otherwise. So I'm not sure what the right thing is here.

I don't understand the link between this change of behavior and the issues you linked above. Could you detail this?

@kit-ty-kate
Copy link
Member Author

The link between this PR and the issuses is that camlp4 was using the reference Option.use_ocamlfind in order to disable that option. In the case of camlp4 it can use the command line option because it don't need backward compatibility. But if you need the backward compatibility (>= 3.12.1) and you don't want to use ocamlfind, you have to use Option.use_ocamlfind in the plugin because it exists since then which is not the case for the command line option. If you do that, ocamlbuild still rely on ocamlfind in the early stage (the compilation of the plugin). This patch try to fix this.

@gasche
Copy link
Member

gasche commented May 4, 2014

Maybe the better solution is to revert making -use-ocamlfind the default. Various people have complained that changing default behavior is never good, and they have a point.

@kit-ty-kate
Copy link
Member Author

Of course, this would be a descent solution. I'm agree with it.

@hcarty
Copy link
Member

hcarty commented May 21, 2014

I would much rather have ocamlfind enabled by default. It would be the desired configuration for most users - why not have it be the default in the tool?

@whitequark
Copy link
Member

I agree with @hcarty; the packages which do not use ocamlfind are the minority.

@gasche
Copy link
Member

gasche commented May 22, 2014

@gasche gasche closed this Jun 4, 2014
lpw25 pushed a commit to lpw25/ocaml that referenced this pull request Oct 1, 2014
Fix bug in type marking when replacing variables with abstract types
objmagic added a commit to objmagic/ocaml that referenced this pull request Nov 19, 2017
chenglou pushed a commit to chenglou/ocaml that referenced this pull request Feb 15, 2019
stedolan pushed a commit to stedolan/ocaml that referenced this pull request Feb 20, 2020
poechsel pushed a commit to poechsel/ocaml that referenced this pull request Jul 2, 2021
lpw25 pushed a commit to lpw25/ocaml that referenced this pull request Oct 12, 2021
Local allocation prototype: initial type system plumbing and backend support
lpw25 pushed a commit to lpw25/ocaml that referenced this pull request Oct 12, 2021
lpw25 pushed a commit to lpw25/ocaml that referenced this pull request Nov 12, 2021
stedolan added a commit to stedolan/ocaml that referenced this pull request May 24, 2022
173842c Merge flambda-backend changes
ed7eba2 Remove leading space from LINE. (oxcaml/oxcaml#484)
bd61170 Bump magic numbers (ocaml#5)
c50c47d Add CI builds with local allocations enabled
1412792 Move local allocations support behind '-extension local'
6d8e42a Better tail call behaviour in caml_applyN
c7dac3d Typemod: toplevel bindings escape even if no variables are bound
82d6c3e Several fixes for partial application and currying
d05c70c Pprintast support for new local syntax
e0e62fc Typecheck x |> f y as (f y x), not ((f y) x)
d7e34ce Remove autogeneration of @ocaml.curry
b9a0593 Port oxcaml/oxcaml#493
0a872d9 Code review fixes from oxcaml/oxcaml#491
6c168bb Remove local allocation counting
3c6e7f0 Code review fixes from oxcaml/oxcaml#478
bb97207 Rename Lambda.apply_position
a7cb650 Quieten Makefile when runtime dep files are not present
c656dc9 Merge flambda-backend changes
11b5424 Avoid printing double spaces in function argument lists
7751faa Restore locations to Typedtree.{pat,let}_bound_idents_full
e450b6c add build_ocaml_compiler.sexp
0403bb3 Revert PR 9895 to continue installing VERSION
b3447db Ensure new local attributes are namespaced properly
7f213fc Allow empty functions again
8f22ad8 Bugfix: ensure local domain state is initialised
80f54dd Bugfix for Selectgen with regions
e8133a1 Fix external-external signature inclusion
9840051 Bootstrap
d879f23 Merge remote-tracking branch 'jane/local-reviewed' into local-merge
94454f5 Use Local_store for the local allocations ref
54a164c Create fewer regions, according to typechecking (ocaml#59)
1c2479b Merge flambda-backend changes
ce34678 Fix printing of modes in return types
91f2281 Hook mode variable solving into Btype.snapshot/backtrack
54e4b09 Move Alloc_mode and Value_mode to Btype
ff4611e Merge flambda-backend changes
ce62e45 Ensure allocations are initialised, even dead ones
6b6ec5a Fix the alloc.ml test on 32-bit builds
81e9879 Merge flambda-backend changes
40a7f89 Update repo URL for ocaml-jst, and rename script.
0454ee7 Add some new locally-allocating primitives (ocaml#57)
8acdda1 Reset the local stack pointer in exception handlers (ocaml#56)
8dafa98 Improve typing for (||) and (&&) (ocaml#55)
8c64754 Fix make_check_all_arches (ocaml#54)
b50cd45 Allow arguments to primitives to be local even in tail position (ocaml#53)
cad125d Fix modes from or-patterns (ocaml#50)
4efdb72 Fix tailcalls tests with inlining (ocaml#52)
4a795cb Flambda support (ocaml#49)
74722cb Add [@ocaml.principal] and [@ocaml.noprincipal] attributes, and use in oo.mli
6d7d3b8 Ensure that functions are evaluated after their arguments (flambda-backend ocaml#353)
89bda6b Keep Sys.opaque_identity in Cmm and Mach (port upstream PR 9412)
a39126a Fix tailcalls within regions (ocaml#48)
4ac4cfd Fix stdlib manpages build
3a95f5e Merge flambda-backend changes
efe80c9 Add jane/pull-flambda-patches script
fca94c4 Register allocations for Omitted parameter closures (ocaml#47)
103b139 Remove various FIXMEs (ocaml#46)
62ba2c1 Bootstrap
a0062ad Allow local allocations for various primitives (ocaml#43)
7a2165e Allow primitives to be poly-moded (ocaml#43)
2af3f55 Fix a flaky test by refactoring TypePairs (ocaml#10638)
58dd807 Bootstrap
ee3be10 Fix modes in build_apply for partial applications
fe73656 Tweak for evaluation order of labelled partial applications (ocaml#10653)
0527570 Fix caml_modify on local allocations (ocaml#40)
e657e99 Relax modes for `as` patterns (ocaml#42)
f815bf2 Add special mode handling for tuples in matches and let bindings (ocaml#38)
39f1211 Only take the upper bounds of modes associated with allocations (ocaml#37)
aec6fde Interpret arrow types in "local positions" differently
c4f3319 Bootstrap
ff6fdad Add some missing regions
40d586d Bootstrap
66d8110 Switch to a system with 3 modes for values
f2c5a85 Bugfix for Comballoc with local allocations. (ocaml#41)
83bcd09 Fix bug with root scanning during compaction (ocaml#39)
1b5ec83 Track modes in Lambda.lfunction and onwards (ocaml#33)
f1e2e97 Port ocaml#10728
56703cd Port ocaml#10081
eb66785 Support local allocations in i386 and fix amd64 bug (ocaml#31)
c936b19 Disallow local recursive non-functions (ocaml#30)
c7a193a GC support for local allocations (ocaml#29)
8dd7270 Nonlocal fields (ocaml#28)
e19a2f0 Bootstrap
694b9ac Add syntax to the parser for local allocations (ocaml#26)
f183008 Lower initial stack size
918226f Allow local closure allocations (ocaml#27)
2552e7d Introduce mode variables (ocaml#25)
bc41c99 Minor fixes for local allocations (ocaml#24)
a2a4e60 Runtime and compiler support for more local allocations (ocaml#23)
d030554 Typechecking for local allocations (ocaml#21)
9ee2332 Bugfix missing from ocaml#20
02c4cef Retain block-structured local regions until Mach.
86dbe1c amd64: Move stack realloc calls out-of-line
324d218 More typing modes and locking of environments
a4080b8 Initial version of local allocation (unsafe)

git-subtree-dir: ocaml
git-subtree-split: 173842c
stedolan pushed a commit to stedolan/ocaml that referenced this pull request May 24, 2022
ce88833 Merge flambda-backend changes
b7506bb Revert "Cherry-pick of ocaml/ocaml 1eeb0e7 (ocaml#12)"
183f688 Add config option to enable/disable stack allocation (ocaml#22)
ee7c849 If both the type and mode of an ident are wrong, complain about the type. (ocaml#19)
44bade0 Allow submoding during module inclusion checks (ocaml#21)
de3bec9 Add subtyping between arrows of related modes (ocaml#20)
93d8615 Enable the local keywords even when the local extension is off (ocaml#18)
81dd85e Documentation for local allocations
b05519f Fix a GC bug in local stack scanning (ocaml#17)
9f879de Fix __FUNCTION__ (ocaml#15)
a78975e Optimise "include struct ... end" in more cases (ocaml#11134)
b819c66 Cherry-pick of ocaml/ocaml 1eeb0e7 (ocaml#12)
bb363d4 Optimise the allocation of optional arguments (ocaml#11)

git-subtree-dir: ocaml
git-subtree-split: ce88833
lpw25 added a commit to lpw25/ocaml that referenced this pull request Jun 21, 2022
OlivierNicole added a commit to fabbing/ocaml that referenced this pull request Mar 16, 2023
EmileTrotignon pushed a commit to EmileTrotignon/ocaml that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants