Pervasives: define [min_int] and [max_int] without assuming that integers are either 31 or 63 bits#19
Closed
vouillon wants to merge 1 commit intoocaml:trunkfrom
Closed
Pervasives: define [min_int] and [max_int] without assuming that integers are either 31 or 63 bits#19vouillon wants to merge 1 commit intoocaml:trunkfrom
vouillon wants to merge 1 commit intoocaml:trunkfrom
Conversation
integers are either 31 or 63 bits. Js_of_ocaml has 32 bit integers. Currently, it patches the bytecode, just to get the correct values for [min_int] and [max_int]. It would be simpler if this was not necessary.
Member
|
Seems fine to me. Can bit hackers confirm? |
Member
|
Looks good to me. |
|
Another LGTM FWIW. |
7 tasks
Member
|
Commited in trunk (14477). Thanks! |
lpw25
pushed a commit
to lpw25/ocaml
that referenced
this pull request
Oct 1, 2014
Add forward type propagation over implicit function definitions
stedolan
added a commit
to stedolan/ocaml
that referenced
this pull request
Aug 18, 2015
Fixing is_main initialization in create_domain.
lpw25
pushed a commit
to lpw25/ocaml
that referenced
this pull request
Dec 22, 2015
Add O2, O3 to OCAMLPARAM
This was referenced Mar 14, 2019
Closed
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
May 24, 2022
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
May 24, 2022
ce88833 Merge flambda-backend changes b7506bb Revert "Cherry-pick of ocaml/ocaml 1eeb0e7 (ocaml#12)" 183f688 Add config option to enable/disable stack allocation (ocaml#22) ee7c849 If both the type and mode of an ident are wrong, complain about the type. (ocaml#19) 44bade0 Allow submoding during module inclusion checks (ocaml#21) de3bec9 Add subtyping between arrows of related modes (ocaml#20) 93d8615 Enable the local keywords even when the local extension is off (ocaml#18) 81dd85e Documentation for local allocations b05519f Fix a GC bug in local stack scanning (ocaml#17) 9f879de Fix __FUNCTION__ (ocaml#15) a78975e Optimise "include struct ... end" in more cases (ocaml#11134) b819c66 Cherry-pick of ocaml/ocaml 1eeb0e7 (ocaml#12) bb363d4 Optimise the allocation of optional arguments (ocaml#11) git-subtree-dir: ocaml git-subtree-split: ce88833
lpw25
pushed a commit
to lpw25/ocaml
that referenced
this pull request
Jun 21, 2022
OlivierNicole
added a commit
to fabbing/ocaml
that referenced
this pull request
Mar 16, 2023
Fix tests in CI builds
turly221
pushed a commit
to scantist-ossops-m2/ocaml
that referenced
this pull request
Nov 30, 2024
MPR#7702: refresh raise counts when inlining a function (ocaml#1553)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Js_of_ocaml has 32 bit integers. Currently, it patches the bytecode, just to get the correct values for [min_int] and [max_int]. It would be simpler if this was not necessary.