Allow custom warning printers / catchers.#171
Closed
klakplok wants to merge 1 commit intoocaml:trunkfrom
Closed
Conversation
Member
|
I like this patch, the new code is actually cleaner than the original. |
Member
|
Merged in trunk, thanks! |
mshinwell
pushed a commit
to mshinwell/ocaml
that referenced
this pull request
Jun 17, 2020
lthls
added a commit
to lthls/ocaml
that referenced
this pull request
Sep 23, 2020
lthls
added a commit
to lthls/ocaml
that referenced
this pull request
Sep 23, 2020
lthls
added a commit
to lthls/ocaml
that referenced
this pull request
Sep 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing alternative toplevels (such as tryocaml), one can catch errors to display them in a custom way, but doing so for warnings is not possible, except by parsing the output. This patch adds a hook for doing so.
I tried to make this patch minimal, but for the current error underlining to continue working with custom warning printers, I had to move some formatter patching code (that counts the '\n' present in Warning messages) from Warnings to Location.
I also added a hook for displaying errors, for consistency.