lexer raise for literals followed by alphanum#155
Conversation
parsing/lexer.mli
Outdated
There was a problem hiding this comment.
Literal_malformed does not sound like proper english to me. It should be Malformed_literal -- or maybe the more neutral Invalid_literal.
There was a problem hiding this comment.
True. This was only to get a common prefix with Literal_overflow.
Invalid_literal seems better anyway.
parsing/lexer.mll
Outdated
There was a problem hiding this comment.
What's the point of the star here? You want to raise as soon as you see one identchar, and you don't want to raise if there are none.
There was a problem hiding this comment.
The star should probably be a plus.
The error Invalid literal 0o18 seems weird when trying to lex 0o1823
There was a problem hiding this comment.
Indeed, a plus would be more robust.
|
Merged in trunk. Thanks! |
|
FTR, this change broke (at least) the following OPAM packages:
|
|
Would you have the code snippets that break? Just curious. |
|
For archimedes: For cubicle: For caml2html, it's in a file designed to torture-test the parser, see mjambon/caml2html#3 |
* Use bytecode version for Lazy.force inlining * Extend lazy_invalid test
* Use bytecode version for Lazy.force inlining * Extend lazy_invalid test
* Use bytecode version for Lazy.force inlining * Extend lazy_invalid test
* Use bytecode version for Lazy.force inlining * Extend lazy_invalid test
…bda...) and source code. (ocaml#155) Add printers able to track mappings between source code and intermediate representations
* add rescript:format task for manual formatting and add minimal vscode extension settings
* Add very simple tab-completion to the toplevel This is based on uTop's implementation, with all of the utf-8 parts stripped out. Unfortunately compiling camomile with js_of_ocaml was causing an error early during initialisation. I've kept the uTop modules in the same structure they were originally so it's easy to reinstate if camomile gets fixed or if we find a suitable replacement. The UI/UX/DX could do with some love! * Add toplevel-completion to CHANGES.md * Add cppo preprocessed files to .ocamlformat-ignore
3 participants
http://caml.inria.fr/mantis/view.php?id=6816