Parser: allow seq_expr inside extended indexing/bigarray operators#1467
Parser: allow seq_expr inside extended indexing/bigarray operators#1467damiendoligez merged 3 commits intoocaml:trunkfrom
Conversation
|
This allows to write |
|
Answering to myself: No, it allows |
|
Answering to myself: No, it allows
|
|
(of course The PR is just fine and the proposal is obviously reasonable, so I don't see any reason to argue against it. Unless someone finds an actual reason, I'll merge at some point starting next week. (Feel free to ping me if I forgot.) |
damiendoligez
left a comment
damiendoligez
left a comment
There was a problem hiding this comment.
Reviewed and approved. You'll need a Changes entry.
|
|
|
Unless there is dissent, I am going to revert this in the following days to leave space for maybe merging #1726 in some later point in the future. |
|
@gasche ping |
|
Thanks for the ping! I'm going to revert today. I hesitate between reverting from just 4.07 or also in trunk. |
…ators (ocaml#1467)" This reverts commit 6664b06.
…ators (ocaml#1467)" This reverts commit 6664b06.
4 participants
By analogy with the case of array and string indexing operators, the PR changes the parser so that the thing used inside extended indexing/bigarray operators is allowed to be a
seq_exprinstead of simply anexpr. While this "feature" is surely not used much, the intent here is to keep the concrete syntax as uniform as possible.