Add line number breakpoints to ocamldebug#14350
Add line number breakpoints to ocamldebug#14350joelreymont wants to merge 1 commit intoocaml:trunkfrom
Conversation
testsuite/tests/tool-debugger/line-breakpoints/test_module_colon_syntax.ml
Outdated
Show resolved
Hide resolved
Implements line number breakpoint support for ocamldebug, allowing breakpoints to be set at function entry points using line numbers. Features: - Inclusive event lookup that includes Event_pseudo function entries - New Module:line syntax (e.g., "break Foo:42") - Maintains backward compatibility with existing @ syntax - Test suite integrated into OCaml's testsuite Implementation: - New event_at_pos_inclusive and event_near_pos_inclusive functions - Updated breakpoint command handlers to use inclusive lookups - Added Module:line parser rule in debugger_parser.mly - Uses existing all_events_by_module hashtable (converted to array as needed) Testing: - Automated tests in testsuite/tests/tool-debugger/line-breakpoints/ - Tests use TEST_BELOW format for line number stability
508e76d to
92dd495
Compare
|
Assuming You can then do |
|
The AI-generated summary of this PR is mostly useless. Could you clarify what this PR was meant to achieve, beyond allowing one to write |
|
I couldn't find the option to Is this a facepalm moment? |
|
Well, the code itself looks like you needed some kind of support for stopping at function entry points; it would be nice to know if that is an issue (that your PR fixes) or not. |
|
That's an unintended side effect, I didn't mean that specifically. |
|
Looks like this PR is useless in the end since stopping at line numbers is already implemented. Should I narrow it down to, for example, stopping at function entry points if the compiler has emitted that information? |
|
Do you have an example where doing this would improve on the user-observable behavior? |
I do not if you are asking me. |
|
There doesn't seem to be anything new in this PR that doesn't exist already. So closing. Thanks. |
Implements line number breakpoint support for ocamldebug, allowing breakpoints to be set at function entry points using line numbers.
Features:
Testing: