Skip to content

Turn the Lfunction case of Lambda.lambda in a record#133

Closed
chambart wants to merge 3 commits intoocaml:trunkfrom
chambart:lfunction_record
Closed

Turn the Lfunction case of Lambda.lambda in a record#133
chambart wants to merge 3 commits intoocaml:trunkfrom
chambart:lfunction_record

Conversation

@chambart
Copy link
Contributor

@chambart chambart commented Jan 5, 2015

This will simplify adding fields to this case, in particular adding extensions annotations.

@gasche
Copy link
Member

gasche commented Jan 5, 2015

I'm not sure adding trunk language features in the codebase is a good idea; I'd use a non-inline record for now.

@alainfrisch
Copy link
Contributor

Indeed, the standard policy seems to be: wait at least for version N+1 before using features introduced in version N. (A recent counterexample is the use of the deprecated attribute in stdlib.)

@chambart
Copy link
Contributor Author

chambart commented Jan 6, 2015

I commited the missing part (closure.ml).
The patch turning it into an inline record is c94ff39 the rest is identical in both cases.

@chambart
Copy link
Contributor Author

Is there some opposition to that change ?

@gasche
Copy link
Member

gasche commented Feb 25, 2015

I just added this to my merge list (complain if you don't like the change!). I will remove c94ff39 (no inline records).

@chambart
Copy link
Contributor Author

Ok thanks for ::

@gasche
Copy link
Member

gasche commented Apr 12, 2015

Merged in trunk. I didn't include the inline-record patch, and I merged the two others (I understand the split make sense in your codebase, but I prefer to make compilable commits for bisecting convenience.) Thanks for the refactoring work!

@gasche gasche closed this Apr 12, 2015
@gasche gasche mentioned this pull request Apr 12, 2015
chambart pushed a commit to chambart/ocaml-1 that referenced this pull request Aug 4, 2021
stedolan pushed a commit to stedolan/ocaml that referenced this pull request Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants