Fix native flexlink check on Cygwin #13009
Merged
+22
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
force-pushed
the
fix-cygwin-flexlink
branch
from
fbe145a to
acd3671
Compare
Contributor
|
This looks good to me.
while reviewing, I had the thought that `AS_IF([test x"$build" != x"$host"],` is probably overly cautious since, I'm assuming, both
`build` and `host` are guaranteed to be non-empty.
I'm approving but not merging so that you can update the Changes entry,
but feel free to merge once done!
|
shindere
approved these changes
Mar 11, 2024
flexlink needs to be executable from a native Windows process when: - Cross-compiling - Building on Cygwin or MSYS2 Beforehand, only the second check was being made, which had the effect of breaking the Cygwin build when using Cygwin's flexdll package.
dra27
force-pushed
the
fix-cygwin-flexlink
branch
from
acd3671 to
19b571c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #12992, as @jmid reports that the Cygwin build has been broken when flexdll is not being bootstrapped.
flexlink needs to be executable from a native Windows process when:
Beforehand, only the second check was being made, which had the effect of breaking the Cygwin build when using Cygwin's flexdll package.
Tested on both Cygwin and MSYS2.