Fix assertion failure #12817
Merged
Fix assertion failure #12817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Dec 11, 2023
|
Invariant is mentioned on line 448 of |
gasche
approved these changes
Dec 11, 2023
NickBarnes
added a commit
to NickBarnes/ocaml
that referenced
this pull request
Dec 13, 2023
sadiqj
pushed a commit
to sadiqj/ocaml
that referenced
this pull request
Apr 24, 2024
* Import new Gc.Memprof API * Import new statmemprof testsuite * Runtime4 support for new statmemprof testsuite * Port 12383: backtrace abstractions * Import runtime5 statmemprof implementation Ports PRs ocaml#12382, ocaml#12817, ocaml#12824, ocaml#12923, ocaml#13068 * Avoid allocating unnecessarily during bytecode callbacks * Minor statmemprof testsuite robustness fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-liner. A recent statmemprof merge (#12382) had an off-by-one error in an assertion (fixed long ago on the later statmemprof branch). This was breaking the multicore tests.