[RFC] add caml_modify_field and caml_initialize_field#120
Closed
gasche wants to merge 1 commit intoocaml:trunkfrom
Closed
[RFC] add caml_modify_field and caml_initialize_field#120gasche wants to merge 1 commit intoocaml:trunkfrom
gasche wants to merge 1 commit intoocaml:trunkfrom
Conversation
Stephen Dolan reported that he had to do this change as part of his Multicore-OCaml work, and it seems applicable independently of it. This patch does not remove all uses of Field as a lvalue, or all &Field(..) constructs, but only those that fit into the following patterns: caml_modify(&Field(v, idx), w) caml_initialize(&Field(v, idx, w) I had some questions when working on the code, which are marked with "/* GS: ..." comments.
gasche
force-pushed
the
caml_modify_field
branch
from
4556375 to
42ae552
Compare
Member
Author
|
@stedolan, is this close to what you had in mind? |
Member
There was a problem hiding this comment.
This one looks wrong: the destination pointer p used to vary with the loop, now it's a constant. Also, you're still increasing p, which is useless. Try this:
for (i = 0; i < nvars; i++)
caml_initialize_field(accu, nfuncs * 2 - 1 + i, sp[i]);
Also, try to write a test that triggers the problem.
Contributor
|
@gasche do you want so help for moving on this issue? |
Member
Author
|
@bobot please feel free to adopt the issue if you want to push for it now. |
Member
@gasche can you do that within Github? |
Member
Author
|
Well I was thinking of closing this PR and opening another one. If you want to keep a given PR, whoever is interested can send me a PR against my personal branch The reason why I would like to give this PR to someone else (I still think it's a good think to do as soon as possible) are:
|
Contributor
|
I'm going to close this, since @stedolan and @kayceesrk are going to submit a revised proposal for C API changes for 4.05. @stedolan Please take note of comments here anyway, in case they are useful. |
Contributor
|
Sorry I missed this at the time! I've created #1003 with the revised proposal, which is a bit more far-reaching. |
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Jun 9, 2017
ARM64 backend
chambart
pushed a commit
to chambart/ocaml-1
that referenced
this pull request
Aug 4, 2021
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Oct 5, 2021
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Mar 21, 2023
c703f5f Incorporate upstream comments into type-variable refactor (ocaml#121) 362ba23 Constrain curry modes to increase along applications (ocaml#108) b1f0cf9 Simplify the extension handling (ocaml#114) 4fd53a1 Remove pat_mode from typedtree (ocaml#105) cf6fcbc Handle attributes on lambdas with locally abstract types (ocaml#120) 5fa80fe Don't track attributes inside attributes for warning 53 (ocaml#115) 8a69777 Handle unclosed `[: ... :]` patterns (via `Generic_array` machinery) (ocaml#117) b0737f4 Add promote-one Makefile target (ocaml#118) c6ad684 Refactoring and fixes around module lookup (ocaml#107) b0a6495 Add documentation for global constructor arguments (ocaml#69) dd79aec Print `nlocal` in the `-d(raw)lambda` output (ocaml#112) 8035026 Fix `nlocal` in the generated Lambda for list comprehensions (ocaml#113) afbcdf0 Immutable arrays (ocaml#47) bfe1490 fix several issues when removing exp_mode (ocaml#110) 8f46060 Better error message for under-applied functions (ocaml#74) 27331d8 Consistently use Lmutvar or Lvar in comprehensions (ocaml#111) 01e965b Skip failing test for now 0131357 Fix test case to use comprehensions_experimental 22a7368 Temporarily disable list comprehensions tests due to locals bug e08377d Make `comprehensions` into `comprehensions_experimental` for now (ocaml#109) 947cf89 List and array comprehensions (ocaml#46) bd9e051 remove exp_mode from typedtree (ocaml#100) a9268d2 Fix misplaced attribute warning when using external parser (and some cleanup) (ocaml#101) 2b33f24 Refactor toplevel local escape check (ocaml#104) ed2aec6 Comment functions exported from TyVarEnv. 87838ba Move new variable creation into TyVarEnv. a3f60ab Encapsulate functions that work with tyvars 43d83a6 Prevent possibility of forgetting to re-widen 2f3dd34 Encapsulate context when narrowing type env't d78ff6d Make immediate64 things mode cross (ocaml#97) aa25ab9 Fix version number (ocaml#94) d01ffa0 Fix .depend file (ocaml#93) 942f2ab Bootstrap (ocaml#92) 05f7e38 Check Menhir version (ocaml#91) 1569b58 Move the CI jobs from 4.12 to 4.14. (ocaml#90) git-subtree-dir: ocaml git-subtree-split: c703f5f
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stephen Dolan reported that he had to do a related change as part of his Multicore-OCaml work, and it seems applicable independently of it.
This patch does not remove all uses of
Field(...)as a lvalue, or all&Field(..)constructs, but only those that fit into the following patterns:This is an exploratory patch from someone that doesn't know the runtime very well. I had some questions when working on the code, which are marked with
/* GS: ... */comments.All feedback and comments are welcome.