Skip to content

remove the -force-tmc flag#11661

Merged
xavierleroy merged 1 commit intoocaml:5.0from
gasche:no-force-tmc
Oct 27, 2022
Merged

remove the -force-tmc flag#11661
xavierleroy merged 1 commit intoocaml:5.0from
gasche:no-force-tmc

Conversation

@gasche
Copy link
Member

@gasche gasche commented Oct 24, 2022

-force-tmc was initially implemented by Frédéric Bour as a way to implement "automatic tmc optimization" on top of the default behavior which is "opt-in tmc optimization". We later decided to disable it, because its usage was in tension with the goals we were setting for the opt-in mode (in particular: have proper warnings and errors when something that could be unexpected is going on).

It was kept for debugging purposes, and apparently found a way to sneak in the final merge for TMC (very probably my mistake), but in a state where it is actually a no-op.

Note: this PR is against 5.0, it would have to be cherry-picked in trunk as well.

-force-tmc was initially implemented by Frédéric Bour as a way to
implement "automatic tmc optimization" on top of the default behavior
which is "opt-in tmc optimization". We later decided to disable it,
because its usage was in tension with the goals we were setting for
the opt-in mode (in particular: have proper warnings and errors when
something that could be unexpected is going on).

It was kept for debugging purposes, and apparently found a way to
skean in the final merge for TMC (very probably my mistake), but in
a state where it is actually a no-op.
Copy link
Contributor

@nojb nojb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Octachron
Copy link
Member

I am wondering if we should cherry-pick the change to 4.14 since the option is broken there too.

@gasche
Copy link
Member Author

gasche commented Oct 24, 2022

Ah, yes, my bad. Cherry-picking to 4.14 should be fine, and it is reasonable to assume that 4.x will see a couple extra maintenance releases.

@xavierleroy xavierleroy merged commit a7fbbfa into ocaml:5.0 Oct 27, 2022
xavierleroy pushed a commit that referenced this pull request Oct 27, 2022
-force-tmc was initially implemented by Frédéric Bour as a way to
implement "automatic TMC optimization" on top of the default behavior
which is "opt-in TMC optimization". We later decided to disable it,
because its usage was in tension with the goals we were setting for
the opt-in mode (in particular: have proper warnings and errors when
something that could be unexpected is going on).

It was kept for debugging purposes, and apparently found a way to
skean in the final merge for TMC (very probably my mistake), but in
a state where it is actually a no-op.

(cherry picked from commit a7fbbfa)
xavierleroy pushed a commit that referenced this pull request Oct 27, 2022
-force-tmc was initially implemented by Frédéric Bour as a way to
implement "automatic TMC optimization" on top of the default behavior
which is "opt-in TMC optimization". We later decided to disable it,
because its usage was in tension with the goals we were setting for
the opt-in mode (in particular: have proper warnings and errors when
something that could be unexpected is going on).

It was kept for debugging purposes, and apparently found a way to
skean in the final merge for TMC (very probably my mistake), but in
a state where it is actually a no-op.

(cherry picked from commit a7fbbfa)
@xavierleroy
Copy link
Contributor

Merged in trunk, 5.0, and 4.14.

stedolan pushed a commit to stedolan/ocaml that referenced this pull request Mar 21, 2023
a09392d Set Menhir version back to 20210419 again (ocaml#89)
cc63992 Merge pull request ocaml#88 from mshinwell/flambda-backend-changes-2022-12-27
3e49df3 HACKING.jst.adoc
1866676 Merge flambda-backend changes
e012992 Merge pull request ocaml#87 from mshinwell/merge-4.14.1
ac5c7c8 Merge tag '4.14.1' into main
3da21bc add a useful debug printer
83b7c72 Document the debug_printers script
98896e0 Remove a tiny code stutter I came across
99cb5d9 release 4.14.1
b49060f last commit before tagging 4.14.1
fae9aef Add documentation
708e5a9 Add tests
c609eee Bootstrap
7f922d0 Polymorphic parameters
51aeb04 Keep generalized structure from patterns when typing let
4b68bb3 Add test of princiaplity from polymorphic type constraints
82c7afe fix wong raise
aca252f x86: Force result of Icomp to be in a register (ocaml#11808)
985725b Add dynlink_compilerlibs.mli to .gitignore (ocaml#79)
2b1fa24 Regenerate parser (ocaml#80)
1bb6c79 Merge pull request ocaml#78 from mshinwell/flambda-backend-patches-2022-12-13
9029581 Update otherlibs/dynlink/Makefile
3e4f1b9 Revert toplevel/native/dune to ocaml-jst version
6061e4c Regenerate configure using autoconf 2.71
888d4b1 Back out patch which disables alloc-check in ocaml-jst
a6d5796 Fix dynlink build
3e46daf Update .depend files
a5c547e Bootstrap
a6a9031 Merge flambda-backend changes
0ac7fdd temp fix for linker error (ocaml#77)
1018602 Remove references to 32-bit Cygwin (ocaml#11797)
e2d0d9e Enable individual testing with Makefile.jst (ocaml#76)
f10cbf6 increment version number after tagging 4.14.1~rc1
11c5ab7 release 4.14.1~rc1
e4c3920 last commit before tagging 4.14.1~rc1
9e598ca Merge pull request ocaml#11793 from dra27/then-than
2a7e501 Use a more relaxed mode for unification in Ctype.subst (ocaml#11771) (ocaml#73)
7b35ef7 Statically initialize `caml_global_data` with a valid value (ocaml#11788)
cbd791a Allow immediates to cross modes (ocaml#58)
85a0817 Merge pull request ocaml#11534 from gasche/follow-synonyms-in-show-module-type
699f43c Changes
e54e9bc fix the 'stuttering' issue in #show
d9799d3 test comments
fec3b23 follow synonyms when #show-ing module types
06a1ad7 regression tests for ocaml#11533 (still failing)
549d757 Run "misplaced attributes" check when compiling mlis (ocaml#72)
b2b74bf Fix bug in `Mtype.strengthen_lazy` causing spurious typing errors (ocaml#11776)
a6c0e75 Ensure that Ctype.nongen always calls remove_mode_variables (ocaml#70)
6c50831 array elements are global (ocaml#67)
bc510ed Ensure that types from packed modules are always generalised (ocaml#11732)
4d47036 Fix ocaml#10768
8788ff6 Add/move some documentation
9891a36 Propagate location information to `local_` in expressions
988306d Add support for `global_` and `nonlocal_` constructor arguments (ocaml#50)
6729eb8 Missing CAMLparam in win32's Unix.stat (ocaml#11737)
e7dd740 Add debug_printers.ml (ocaml#63)
65f2896 more entries in gitignore (ocaml#62)
a9a84d0 Move `global_flag` to `Asttypes` (ocaml#60)
fac5896 Minor attribute fixes from flambda-backend
75f402e Note about make install and Makefile.jst (ocaml#56)
fb5b1e4 Remove the -force-tmc flag (ocaml#11661)
bd87a61 ocamlmklib: use `ar rcs` instead of `ar rc` (ocaml#11670)
83762af Merge pull request ocaml#11622 from Octachron/fix_recursive_types_in_constructor_mismatch
ca48730 Merge pull request ocaml#11609 from Octachron/pr11194_unbound_and_printing_context

git-subtree-dir: ocaml
git-subtree-split: a09392d
ejgallego pushed a commit to ejgallego/ocaml that referenced this pull request Nov 5, 2025
-force-tmc was initially implemented by Frédéric Bour as a way to
implement "automatic TMC optimization" on top of the default behavior
which is "opt-in TMC optimization". We later decided to disable it,
because its usage was in tension with the goals we were setting for
the opt-in mode (in particular: have proper warnings and errors when
something that could be unexpected is going on).

It was kept for debugging purposes, and apparently found a way to
skean in the final merge for TMC (very probably my mistake), but in
a state where it is actually a no-op.

(cherry picked from commit a7fbbfa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants