Merged
Conversation
mrmr1993
approved these changes
Jun 21, 2022
mrmr1993
approved these changes
Jun 22, 2022
Contributor
Author
|
Thanks. |
Member
|
@garrigue : do you plan to cherry-pick the fix to the 5.0 branch later, or should I take care of it? |
Contributor
Author
|
I'll do it just now. |
garrigue
added a commit
that referenced
this pull request
Jun 22, 2022
Fix #10768: typechecking regression when combining first class modules and GADTs.
Contributor
Author
Member
|
That sounds reasonable to me, #10364 is a rather old bug fix that was frozen during multicore integration. It makes sense to integrate it before the first alpha but let's ask for @trefis's opinion as the reviewer. However, looking at the testsuite changes for #10364, I only see functions with improved error messages, one function that now type in non-principal mode, and two functions that type in principal mode but with a warning. Do you have an example of a program that no longer typecheck? |
Contributor
Author
|
You're right. The principal mode is stricter, but only for warnings, so this makes sense to cherry-pick it. |
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Sep 27, 2023
…request PR#12198 from shindere/merge-debugger-makefile Merge debugger/Makefile into the root Makefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative fix to #10768.
Compared to #11339, it duplicates types of first class modules, the same way as in
Typecore.type_cases, rather than disabling scope checking, which is potentially dangerous.