Merged
Conversation
The allocated memory blocks are freed in the custom block finaliser, so it isn't necessary to use a more complicated memory manager.
Contributor
|
Looks good to me! Merging right now... |
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
…AML (ocaml#1121) When changing the YAML parsing in watch.ml to use the yoshi tool, watch.yaml was turned into a list of watch entries, instead of this list being part of a struct. watch_scrape.ml was not updated accordingly. This patch updates watch_scrape.ml to emit a YAML list of watch entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In comments to the recently merged #71 @alainfrisch pointed out that perhaps it'd suffice to use plain
mallocandfreeinside Bigarray instead of the more complicatedcaml_stat_*. I have validated his suggestion, and this patch implements it.No separate Changes entry is needed, as it's merely a fixup to #71.