ocamldep: add -plugin and use compilerlibs to build#1015
ocamldep: add -plugin and use compilerlibs to build#1015lefessan merged 3 commits intoocaml:trunkfrom
Conversation
lefessan
force-pushed
the
2017-01-18-ocamldep-plugin
branch
from
97a29d5 to
dde82f2
Compare
|
Possibly applying Holmes deduction - it's much easier to restart CI tests by signing into Travis (with your GitHub ID - the initial auth is very quick) and restarting the specific run! |
|
The problem here is not Travis, but Appveyor, and I don't see any "restart build" button on Appveyor... |
|
AppVeyor seems to be clogged up - I don't know why |
lefessan
force-pushed
the
2017-01-18-ocamldep-plugin
branch
from
2389d36 to
8009c79
Compare
lefessan
force-pushed
the
2017-01-18-ocamldep-plugin
branch
from
8009c79 to
a676907
Compare
|
Rebased, no bootstrap anymore. I think the lack of |
|
Would it be possible to add an entry to ocamldep man page and manual description? Since plugins can modify dependencies, I concur with you that the lack of plugin support for ocamldep is a bug. |
|
Fabrice Le Fessant (2017/02/26 13:25 -0800):
Rebased, no bootstrap anymore. I think the lack of `-plugin` in
`ocamldep` is a bug and should be fixed for 4.05.0 .
What would the -plugin option do, actually?
|
@shindere It does the same as for ocamlc/ocamlopt, i.e. load a .cmxs/.cma into the tool, to extend its capability. It can do the same as ppx, but also work on the typedtree or add optimizations, if the hooks are available. |
|
OK thanks, so it would be useful for e.g. ocamllex and perhaps every
tool I guess...
a
|
|
There were already some hooks in the compiler and I added other ones, for example a plugin can add a hook to map on the Typedtree (for example, Pierrick's |
|
Reviewed. OK for trunk and 4.05 when the manual is updated. |
* ocamldep: add -plugin argument, and use compilerlibs to build
|
Manual updated, PR squashed-merged in trunk, commit cherry-picked to 4.05. |
* ocamldep: add -plugin argument, and use compilerlibs to build
* Printing changes * More precise effects and coeffects when substituting variables * Immediately split must_inline_and_duplicate bindings * Full fix * make fmt * New CR + bugfix for ece downgrading * fmt * Add comments * typo
* unified package overview/docs layout Rearranges package overview and documentation such that: * package_layout.eml defines the two sidebars and the content area * there is a navigation element to switch between Overview (About) and Documentation (Docs) * there is a placeholder element for the upcoming in-package search (to remind us how important this feature is and to show users that we have a plan where it goes) Consequences: * package overview page now has a collapsing sidebar with a button to slide it in on small screens * package documentation now has a tablet (md) layout that shows the sidebar on-screen, instead of collapsed * add text-sm which was lost during unification * "Overview" instead of "About" since we have the space
* make package documentation link more obvious (ocaml#828) * make documentation link more obvious * minor style improvement Co-Authored-By: Sabine Schmaltz <[email protected]> * improve authors/maintainers display on package overview (ocaml#1001) * refactor package urls, routes, and handlers (ocaml#999) * refactor package urls, routes, and handlers * move package redirects to redirection.ml * Unify package overview and documentation layout (ocaml#1015) * unified package overview/docs layout Rearranges package overview and documentation such that: * package_layout.eml defines the two sidebars and the content area * there is a navigation element to switch between Overview (About) and Documentation (Docs) * there is a placeholder element for the upcoming in-package search (to remind us how important this feature is and to show users that we have a plan where it goes) Consequences: * package overview page now has a collapsing sidebar with a button to slide it in on small screens * package documentation now has a tablet (md) layout that shows the sidebar on-screen, instead of collapsed * add text-sm which was lost during unification * "Overview" instead of "About" since we have the space * Add support for sitemap.xml * Generate sitemap.xml by dream * Apply suggestions from @cuihtlauac code review Co-authored-by: Cuihtlauac Alvarado <[email protected]> * Convert lists of urls to sequences and change names of functions * Apply suggestions from @cuihtlauac code review 2 Co-authored-by: Cuihtlauac Alvarado <[email protected]> * Delete subdomains URLs and URLs returning status code other than 200 * Apply suggestions from @cuihtlauac code review 3 Co-authored-by: Cuihtlauac Alvarado <[email protected]> * Update PR * formating * do not touch playground asset * Apply suggestions from @cuihtlauac code review 4 * Apply suggestions from @cuihtlauac code review 5 * Apply suggestions from @cuihtlauac code review 6 * Apply suggestions from @cuihtlauac code review 7 * Apply suggestions from @cuihtlauac code review 8 --------- Co-authored-by: Sabine Schmaltz <[email protected]> Co-authored-by: sabine <[email protected]> Co-authored-by: Cuihtlauac Alvarado <[email protected]>
5 participants
This PR simply adds the option
-plugin PLUGINtoocamldep, as it might be useful to extendocamldepwith the same plugins asocamlc.It also bootstraps the compiler (in a separate commit), so that
ocamlccan also use the new ability for plugins to define arguments.