Improve wording of inlining reports#1001
Merged
mshinwell merged 1 commit intoocaml:trunkfrom Jan 13, 2017
Merged
Conversation
Member
|
It seems that the size payload of the |
Contributor
Author
|
IIRC we stop calculating the size of the function once it hits the threshold so we don't normally have both available. |
Contributor
|
Yeah, I believe that's right, it's a compile-time performance optimisation. |
Member
|
(I believe the patch is fine but I'm a bit confused as to why the Changes CI check is not passing. Will hopefully investigate later. Feel free to merge before that.) |
camlspotter
pushed a commit
to camlspotter/ocaml
that referenced
this pull request
Oct 17, 2017
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Mar 21, 2023
Co-authored-by: Vincent Laviron <[email protected]>
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
* make package documentation link more obvious (ocaml#828) * make documentation link more obvious * minor style improvement Co-Authored-By: Sabine Schmaltz <[email protected]> * improve authors/maintainers display on package overview (ocaml#1001) * refactor package urls, routes, and handlers (ocaml#999) * refactor package urls, routes, and handlers * move package redirects to redirection.ml * Unify package overview and documentation layout (ocaml#1015) * unified package overview/docs layout Rearranges package overview and documentation such that: * package_layout.eml defines the two sidebars and the content area * there is a navigation element to switch between Overview (About) and Documentation (Docs) * there is a placeholder element for the upcoming in-package search (to remind us how important this feature is and to show users that we have a plan where it goes) Consequences: * package overview page now has a collapsing sidebar with a button to slide it in on small screens * package documentation now has a tablet (md) layout that shows the sidebar on-screen, instead of collapsed * add text-sm which was lost during unification * "Overview" instead of "About" since we have the space * Add support for sitemap.xml * Generate sitemap.xml by dream * Apply suggestions from @cuihtlauac code review Co-authored-by: Cuihtlauac Alvarado <[email protected]> * Convert lists of urls to sequences and change names of functions * Apply suggestions from @cuihtlauac code review 2 Co-authored-by: Cuihtlauac Alvarado <[email protected]> * Delete subdomains URLs and URLs returning status code other than 200 * Apply suggestions from @cuihtlauac code review 3 Co-authored-by: Cuihtlauac Alvarado <[email protected]> * Update PR * formating * do not touch playground asset * Apply suggestions from @cuihtlauac code review 4 * Apply suggestions from @cuihtlauac code review 5 * Apply suggestions from @cuihtlauac code review 6 * Apply suggestions from @cuihtlauac code review 7 * Apply suggestions from @cuihtlauac code review 8 --------- Co-authored-by: Sabine Schmaltz <[email protected]> Co-authored-by: sabine <[email protected]> Co-authored-by: Cuihtlauac Alvarado <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a couple of changes to the wording of the inlining reports. One message was previously using the word "specialised" when talking about inlining, which seemed to confuse people in relation to our use of "specialised" to refer to copies of recursive functions. The other is changed to explicitly refer to the size threshold, since the phrase "obviously too large" was not particularly informative.