Skip to content

Add META rule for 'compiler-libs.native-toplevel' (ocamltoplevel.cmxa)#4175

Merged
rgrinberg merged 1 commit intoocaml:mainfrom
AltGr:opttoplevel-meta
Feb 14, 2021
Merged

Add META rule for 'compiler-libs.native-toplevel' (ocamltoplevel.cmxa)#4175
rgrinberg merged 1 commit intoocaml:mainfrom
AltGr:opttoplevel-meta

Conversation

@AltGr
Copy link
Member

@AltGr AltGr commented Jan 28, 2021

As per ocaml/ocamlfind#10

Signed-off-by: Louis Gesbert [email protected]

@rgrinberg
Copy link
Member

rgrinberg commented Feb 9, 2021

Hi @AltGr . Do you mind running $ make fmt to make the CI pass?

EDIT: and adding an appropriate CHANGES entry.

@rgrinberg
Copy link
Member

@ejgallego let's include this fix in 2.8.3 as well if you don't mind.

; sub "optcomp" [ "compiler-libs.common" ]
; sub "toplevel" [ "compiler-libs.bytecomp" ]
; sub "toplevel" [ "compiler-libs.bytecomp" ] ~kind:[ Byte ]
; sub "toplevel"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be native-toplevel (cf #4248) ?

rgrinberg added a commit to rgrinberg/opam-repository that referenced this pull request Mar 7, 2021
…ne-action-plugin, dune-private-libs and dune-glob (2.8.3)

CHANGES:

- Make `patdiff` show refined diffs (ocaml/dune#4257, fixes ocaml/dune#4254, @hakuch)

- Fixed a bug that could result in needless recompilation under Windows due to
  case differences in the result of `Sys.getcwd` (observed under `emacs`).
  (ocaml/dune#3966, @nojb).

- Restore compatibility with Coq < 8.10 for coq-lang < 0.3 , document
  that `(using coq 0.3)` does require Coq 8.10 at least (ocaml/dune#4224, fixes
  ocaml/dune#4142, @ejgallego)

- Add a META rule for 'compiler-libs.native-toplevel' (ocaml/dune#4175, @AltGr)

- No longer call `chmod` on symbolic links (fixes ocaml/dune#4195, @dannywillems)

- Dune no longer automatically create or edit `dune-project` files
  (ocaml/dune#4239, fixes ocaml/dune#4108, @jeremiedimino)

- Have `dune` communicate the location of the standard library directory to
  `merlin` (ocaml/dune#4211, fixes ocaml/dune#4188, @nojb)

- Workaround incorrect exception raised by Unix.utimes (OCaml PR#8857) in
  Path.touch on Windows (ocaml/dune#4223, @dra27)

- `dune ocaml-merlin` is now able to provide configuration for source files in
  the `_build` directory. (ocaml/dune#4274, @voodoos)

- Automatically delete left-over Merlin files when rebuilding for the first time
  a project previously built with Dune `<= 2.7`. (ocaml/dune#4261, @voodoos, @aalekseyev)

- Fix `ppx.exe` being compiled for the wrong target when cross-compiling
  (ocaml/dune#3751, fixes ocaml/dune#3698, @toots)

- `dune top` correctly escapes the generated toplevel directives, and make it
  easier for `dune top` to locate C stubs associated to concerned libraries.
  (ocaml/dune#4242, fixes ocaml/dune#4231, @nojb)

- Do not pass include directories containing native objects when compiling
  bytecode (ocaml/dune#4200, @nojb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants