Add versioning for dune auto-formatting style#3946
Merged
nojb merged 1 commit intoocaml:masterfrom Nov 28, 2020
Merged
Conversation
rgrinberg
approved these changes
Nov 13, 2020
Member
|
@nojb anything blocking this? |
Collaborator
Author
No, I thought it was already merged :) I'll run the tests with the current |
Collaborator
Author
Member
|
@nojb did you rebase? that stanza has been renamed |
Signed-off-by: Nicolás Ojeda Bär <[email protected]>
nojb
force-pushed
the
version_dune_formatting
branch
from
a008e64 to
900b0f5
Compare
Collaborator
Author
|
The problem is that |
Collaborator
Author
|
Done in 38e567f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3928 (comment)
This PR adds versioning for the auto-formatting style for the
dunelanguage.The
format-dune-filesubcommand now carries an optional flag--dune-versionto specify the version wanted (note that this command is not used byduneitself, since the formatting is done in-core since Format dune files in core #3536)dune describe,dune printenvanddune inituse the latest version, since it seemed frivolous to add a flag to set the style version.