Stop WSServer on OBS exit#644
Merged
Merged
Conversation
This should fix issues with race conditions and crashes on OBS exit.
eric
force-pushed
the
stop-ws-server-on-exit
branch
from
154afa0 to
9275f7c
Compare
Palakis
approved these changes
Jan 18, 2021
This was referenced Feb 2, 2021
|
This is awesome, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stop the
WSServerwhen receiving the OBS Exit event.Motivation and Context
I have run into crashes on OBS exit due to websocket clients responding to events during teardown. This should fix it by reacting to the exit event and stopping the server.
How Has This Been Tested?
Tested OS(s):
Types of changes
Checklist: