Skip to content

[Bug Fix] Reenable building with captions on MacOS#546

Merged
tt2468 merged 1 commit into
obsproject:4.x-currentfrom
curtgrimes:bugfix/reenable-macos-captions
Jul 1, 2020
Merged

[Bug Fix] Reenable building with captions on MacOS#546
tt2468 merged 1 commit into
obsproject:4.x-currentfrom
curtgrimes:bugfix/reenable-macos-captions

Conversation

@curtgrimes

@curtgrimes curtgrimes commented Jun 30, 2020

Copy link
Copy Markdown

This reverts #477. OBS on MacOS supports closed caption encoding. The Windows-only dependencies here are only related to audio capture, not closed caption encoding.

OBS Studio 25.0.8 and latest version of obs-websocket 4.x built with BUILD_CAPTIONS=true receiving an event originating from obs-websocket-js:

20:14:31.677: [obs-websocket] Request >> '{"text":"hello world! Mon Jun 29 2020 20:14:31 GMT-0500 (Central Daylight Time)","request-type":"SendCaptions","message-id":"39"}'
20:14:31.677: [obs-websocket] Response << '{
20:14:31.677:     "message-id": "39",
20:14:31.677:     "status": "ok"
20:14:31.677: }'

Closed captions appearing in Twitch stream:
Screen Shot 2020-06-29 at 8 13 57 PM

@curtgrimes
[Bug Fix] Reenable building with captions on MacOS
14d43ac 
OBS on MacOS supports closed caption encoding. The Windows-only dependencies [here](https://github.com/obsproject/obs-studio/blob/master/UI/frontend-plugins/frontend-tools/CMakeLists.txt#L73) are only related to audio capture, not closed caption encoding.
@tt2468

tt2468 commented Jun 30, 2020

Copy link
Copy Markdown
Member

If captions are already included regardless of the CMake file, then wouldn't it also support linux too?

@curtgrimes

curtgrimes commented Jun 30, 2020

Copy link
Copy Markdown
Author

I don't have an environment where I can test Linux support at the moment, but on the MacOS side it definitely appears to work.

@tt2468

tt2468 commented Jul 1, 2020

Copy link
Copy Markdown
Member

Tested myself on ubuntu, works great. Merging this since there is nothing to change for Ubuntu.

@tt2468 tt2468 merged commit a4279d0 into obsproject:4.x-current Jul 1, 2020
@curtgrimes

curtgrimes commented Jul 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Author

@tt2468 Thank you! Any chances for a point release? I'm looking to use this in an app soon and it will simplify instructions if I don't need to explain to users how to build this on their own if they're on MacOS.

@tt2468

tt2468 commented Jul 2, 2020

Copy link
Copy Markdown
Member

You can download your pr's macos artifact here, which should include an installer https://dev.azure.com/Palakis/2687c5e1-1f5c-4326-8080-85cbdf4f4033/_apis/build/builds/1288/artifacts?artifactName=macos_build&api-version=5.1&%24format=zip

@arisprung

arisprung commented Nov 22, 2020

Copy link
Copy Markdown

Is this related to the issue I opened here ? #617

If so, How do I fix this?
Thx!

@Palakis

Palakis commented Nov 22, 2020

Copy link
Copy Markdown
Contributor

@arisprung Yes it is!

@Palakis

Palakis commented Nov 22, 2020

Copy link
Copy Markdown
Contributor

@arisprung You can fetch a fresh build of the dev branch here: https://dev.azure.com/Palakis/obs-websocket/_build/results?buildId=1438&view=artifacts&pathAsName=false&type=publishedArtifacts

@arisprung

arisprung commented Nov 22, 2020

Copy link
Copy Markdown

Thx!
What do I need to install? The macos_build is not clickable...
Screen Shot 2020-11-22 at 16 49 36

@tt2468

tt2468 commented Nov 22, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

There is a download arrow on the right side of the row if you hover over it

@bost-ty bost-ty mentioned this pull request Oct 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tt2468 tt2468 tt2468 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@curtgrimes @tt2468 @arisprung @Palakis