cmake: Disable char8_t when using C++20#9194
Merged
Merged
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes compilation when setting the C++ standard to 20+ by disabling
char8_t.Note that while #9183 introduces a deprecation warning in C++20 that gets treated as error,
char8_talso causes failure in other cases wherestd::filesystemis used, such asobs-app.cpp.Motivation and Context
We might want to start using C++20 at some point, and the less said about
char8_tthe better.How Has This Been Tested?
Compiled on Windows with
CMAKE_CXX_STANDARDset to 20.Types of changes
Checklist: