UI: Fix utf-8 paths in shared updater components#9183
Merged
derrod merged 1 commit intoJul 2, 2023
Conversation
derrod
force-pushed
the
fix-unicode-nonsense-frowning-emoji
branch
from
June 30, 2023 18:37
406e480 to
e2cb843
Compare
derrod
force-pushed
the
fix-unicode-nonsense-frowning-emoji
branch
from
June 30, 2023 18:43
e2cb843 to
3e99c01
Compare
Member
Author
|
Confirmed this fixes the update check for usernames (and thus user folders) with special characters on Windows. |
6 tasks
Contributor
|
It seems these changes addresses one part of this: https://obsproject.com/forum/threads/no-gpu-driver-available.167798/post-616613 |
Member
Author
|
Correct. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes reading/writing files with non-ASCII characters in their path in the shared code of the update framework.
Motivation and Context
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
How Has This Been Tested?
Compiled and ran on my machine. Still needs to be tested on an affected system.
Types of changes
Checklist: