CI: Use Qt6 by default when available#6877
Merged
Merged
Conversation
RytoEX
added
kind/bug
PatTheMav
reviewed
Jul 31, 2022
PatTheMav
reviewed
Jul 31, 2022
PatTheMav
reviewed
Jul 31, 2022
Contributor
|
CI builds for Windows platform from this time will run only on Win8.1 and up (dependencies, that were updated here, relay on functions of dxgi library that are specific to newer OSes). |
Member
Author
That's expected and was announced in the pinned May 14 Discussion Post, Plan to Upgrade OBS Studio to Qt 6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use Qt6 by default when available. This applies to the Windows, macOS, and Ubuntu CI jobs.
Motivation and Context
As announced on May 14, we plan to use Qt6 for OBS 28 on platforms where it is available. CI and build scripts should default to Qt6 to encourage adoption of Qt6 by plugin maintainers. This will also help us during our beta and release candidate period.
As stated in the Discussion post, moving to Qt6 also allows us to stop maintaining backported patches, which reduces our maintenance burden.
How Has This Been Tested?
I've verified that CI runs on my fork build with Qt6 when available (Windows, macOS, Ubuntu 22.04) and Qt5 when not available (Ubuntu 20.04). Flatpak will be covered in #6847.
https://github.com/RytoEX/obs-studio/actions/runs/2768057341
Types of changes
Checklist: