Skip to content

UI: Fix YouTube Chat build failure with Qt 6#6672

Merged
RytoEX merged 1 commit into
obsproject:masterfrom
sebastian-s-beckmann:at-least-i-noticed-before-anyone-else-does
Jun 29, 2022
Merged

UI: Fix YouTube Chat build failure with Qt 6#6672
RytoEX merged 1 commit into
obsproject:masterfrom
sebastian-s-beckmann:at-least-i-noticed-before-anyone-else-does

Conversation

@sebastian-s-beckmann

Copy link
Copy Markdown
Member

Description

Replaces a call to QLayout::setMargins recently introduced with the
Qt 6 replacement, setContentsMargins.

Motivation and Context

Keep codebase compatible with Qt 6.

How Has This Been Tested?

Now correctly compiles, YouTube chat looks exactly as it did before

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@sebastian-s-beckmann sebastian-s-beckmann added the kind/bug Categorizes issue or PR as related to a bug. label Jun 29, 2022
@RytoEX

RytoEX commented Jun 29, 2022

Copy link
Copy Markdown
Member

Changes match the changes in #3811. Waiting for CI, then merging.

@RytoEX
RytoEX merged commit cf0275e into obsproject:master Jun 29, 2022
@sebastian-s-beckmann
sebastian-s-beckmann deleted the at-least-i-noticed-before-anyone-else-does branch June 29, 2022 22:37
@RytoEX RytoEX added this to the OBS Studio 28.0 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants