Remove Qt Windows Extra for Qt 6 and later#5654
Merged
Merged
Conversation
tommyvct
force-pushed
the
remove-qtwinextra
branch
from
December 13, 2021 08:39
294479b to
97dc362
Compare
WizardCM
reviewed
Dec 13, 2021
tommyvct
force-pushed
the
remove-qtwinextra
branch
2 times, most recently
from
December 13, 2021 10:24
f0d9933 to
3d0fd7a
Compare
Co-Authored-By: Matt Gajownik <[email protected]>
tommyvct
force-pushed
the
remove-qtwinextra
branch
from
December 13, 2021 10:28
3d0fd7a to
34c454a
Compare
WizardCM
added
the
platform/windows
tommyvct
marked this pull request as ready for review
December 13, 2021 23:43
Member
|
I can't decide if it's fine to have the same check written multiple times, or if there should be a variable that's reused instead. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove Qt Windows Extra for Qt 6 and later
Motivation and Context
Qt 6 and later removed platform-specific extra modules from the code base.
How Has This Been Tested?
It compiles.
Tested on Windows 10 x64 and 11 ARM64 without crash.
Types of changes
Checklist: