Remove X11Extras#4358
Merged
Merged
Conversation
kkartaltepe
approved these changes
Mar 17, 2021
GeorgesStavracas
approved these changes
Mar 17, 2021
GeorgesStavracas
left a comment
Member
There was a problem hiding this comment.
Looks good to me as well :)
Member
Author
|
@kkartaltepe @GeorgesStavracas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Qt5X11Extras (QX11Info) was added in 762983b, but it doesn't seem to actually be used. Qt6 doesn't yet ship X11Extras, so let's remove it.
#3177 added Qt5X11Extras as a dependency, though doesn't actually seem to use classes or functions from it. This was to work around obsproject/obs-browser#219, but that appears to have been resolved by updating to CEF 4280+. Native dialogs were reinstated in 58497e5 (#4155), but we still have Qt5X11Extras as a dependency. Since X11Extras is not currently part of Qt6, and it has no expected ship date, and we aren't using it, let's remove it.
Pinging @cg2121 and @GeorgesStavracas since they authored the PRs linked above.
https://doc.qt.io/qt-5/qtx11extras-module.html
https://doc.qt.io/qt-5/qx11info.html
Motivation and Context
Less dependencies. Makes a future transition to Qt6 easier.
How Has This Been Tested?
Compiles on a Ubuntu 20.04 VM against Qt 5.12.8. Would appreciate more testing or review from people who use Linux regularly.
Types of changes
Checklist: