Description

UI: Replace deprecated QLayout->setMargin with setContentsMargin

Motivation and Context

QLayout->setMargin has been deprecated since Qt 5.13 (though marked obsolete since at least Qt 4.8) and removed in Qt6. It was replaced by QLayout->setContentsMargins, which is available in all versions of Qt5. Building against Qt 5.13+ can produce compiler warnings when using QLayout->setMargin, and warnings are bad.

https://doc.qt.io/archives/qt-4.8/qlayout-obsolete.html
https://doc.qt.io/qt-5/qlayout-obsolete.html
qt/qtbase@d6d33f0
https://github.com/qt/qtbase/blame/5.15.2/src/widgets/kernel/qlayout.h

How Has This Been Tested?

I compiled and ran OBS using Qt 5.15.2 on Windows 10 Home 64-bit 2004 (Build 19041.630) with and without these changes and compared UI elements that had used the old function. Everything looked fine to me. Furthermore, you can see from the Qt commit above that setMargin(int margin) is just an alias for setContentsMargins(margin, margin, margin, margin).

Types of changes

• Bug fix (non-breaking change which fixes an issue)

• Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

• My code has been run through clang-format.
• I have read the contributing document.
• My code is not on the master branch.
• The code has been tested.
• All commit messages are properly formatted and commits squashed where appropriate.
• I have included updates to all appropriate documentation.